[dockers] Rename 'docker-snmp-sv2' to 'docker-snmp' #4699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Jun 3, 2020
@qiluo-msft: Thanks for the heads-up. It's not really related to this PR, but I can make the change here, if you'd like. Looks like the new command line is |
qiluo-msft
previously approved these changes
Jun 3, 2020
|
Retest vsimage please |
5 similar comments
|
Retest vsimage please |
|
Retest vsimage please |
|
Retest vsimage please |
|
Retest vsimage please |
|
Retest vsimage please |
lguohan
previously approved these changes
Jun 9, 2020
lguohan
approved these changes
Jun 9, 2020
|
Retest mellanox please |
|
Retest vsimage please |
3 similar comments
|
Retest vsimage please |
|
Retest vsimage please |
|
Retest vsimage please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-sv2suffix was used to differentiate SNMP Dockers when we transitioned from "SONiCv1" to "SONiCv2", about four years ago. The old Docker materials were removed long ago; there is no need to keep this suffix. Removing it aligns the name with all the other Dockers.Also edit Monit configuration to detect proper snmp-subagent command line in Buster, and make snmpd command line matching more robust.