-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Extend mellanox platform API to report SFP error event #4365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
Apr 3, 2020
platform/mellanox/mlnx-platform-api/sonic_platform/sfp_event.py
Outdated
Show resolved
Hide resolved
platform/mellanox/mlnx-platform-api/sonic_platform/sfp_event.py
Outdated
Show resolved
Hide resolved
platform/mellanox/mlnx-platform-api/sonic_platform/sfp_event.py
Outdated
Show resolved
Hide resolved
platform/mellanox/mlnx-platform-api/sonic_platform/sfp_event.py
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Apr 3, 2020
platform/mellanox/mlnx-platform-api/sonic_platform/sfp_event.py
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Apr 3, 2020
qiluo-msft
reviewed
Apr 3, 2020
platform/mellanox/mlnx-platform-api/sonic_platform/sfp_event.py
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Apr 3, 2020
platform/mellanox/mlnx-platform-api/sonic_platform/sfp_event.py
Outdated
Show resolved
Hide resolved
jleveque
suggested changes
Apr 10, 2020
retest mellanox please |
qiluo-msft
approved these changes
Apr 13, 2020
jleveque
reviewed
Apr 14, 2020
jleveque
approved these changes
Apr 14, 2020
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
…nic-net#4365) * extend mellanox platform API to report SFP error event * remove unnecessary loop code * install enum34 to pmon to support using Enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Extend SFP event API to report SFP error to the upper layer app.
- How I did it
handle SFP event which reported from SDK, log all the detail error type and pass the error event that will block EEPROM accessing to the upper layer.
- How to verify it
test on Mellanox platform
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
This PR has a dependency on sonic-net/sonic-platform-common#80