Bug fix: #4011 #4012 - "show run acl", "show run interfaces" - traceback when no ACL_RULE/INTERFACE is present. #4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LE/INTERFACE is present in configuration - Change logic in main to take data only if the var_json appears in DB. Signed-off-by: Noa Or <noaor@mellanox.com>
jleveque
suggested changes
Mar 6, 2020
|
retest vsimage please |
2 similar comments
|
retest vsimage please |
|
retest vsimage please |
|
@jleveque can you please review unittest and approve? |
jleveque
approved these changes
Mar 30, 2020
liat-grozovik
added
Included in 201911 Branch
Request for 201911 Branch 
and removed
Included in 201911 Branch
labels
abdosi
pushed a commit
that referenced
this pull request
Apr 15, 2020
…ack when no ACL_RULE/INTERFACE is present. (#4226) * Fix bugs - "show run acl/interfaces" returns traceback when no ACL_RULE/INTERFACE is present in configuration - Change logic in main to take data only if the var_json appears in DB. - Add unit testing for bug fix & fix comments Signed-off-by: Noa Or <noaor@mellanox.com>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
…terfaces" - traceback when no ACL_RULE/INTERFACE is present. (sonic-net#4226) * Fix bugs - "show run acl/interfaces" returns traceback when no ACL_RULE/INTERFACE is present in configuration - Change logic in main to take data only if the var_json appears in DB. - Add unit testing for bug fix & fix comments Signed-off-by: Noa Or <noaor@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Noa Or noaor@mellanox.com
- What I did
- How I did it
Change logic in main to take data only if the var given in var_json appears in DB.
- How to verify it
Make sure running configuration doesn't contain ACL_RULE:
show run all | grep -r '"ACL_RULE"'should print nothing.
run command:
show run aclNothing should be printed and no error should appear.
Make sure running configuration doesn't contain INTERFACE:
show run all | grep -r '"INTERFACE"'should print nothing.
run command:
show run interfacesNothing should be printed and no error should appear.
- Description for the changelog
N/A
- A picture of a cute animal (not mandatory but encouraged)