[sonic-yang-models]: First version of yang models for Port, VLan, Interface, PortChannel, loopback and ACL. #3730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
1 similar comment
|
retest this please |
praveen-li
force-pushed
the
sonnic-yang-mgmt-msft
branch
from
de3c076 to
fa42047
Compare
praveen-li
changed the title
praveen-li
changed the title
src/sonic-yang-mgmt/tests/libyang-python-tests/sample-yang-models/sonic-acl.yang
Outdated
Show resolved
Hide resolved
praveen-li
force-pushed
the
sonnic-yang-mgmt-msft
branch
from
fa42047 to
195e7c0
Compare
praveen-li
changed the title
praveen-li
force-pushed
the
sonnic-yang-mgmt-msft
branch
2 times, most recently
from
3282190 to
7614f1f
Compare
praveen-li
force-pushed
the
sonnic-yang-mgmt-msft
branch
from
d275630 to
2f3d185
Compare
|
This pull request introduces 2 alerts when merging 2f3d1854003cd3f2eb939f57d80ef4512bc1ab16 into 7bc8f12 - view on LGTM.com new alerts:
|
added 7 commits
April 8, 2020 12:22
…erface, PortChannel, lopback and ACL. YANG models as per Guidelines. Guideline doc: https://github.com/Azure/SONiC/blob/master/doc/mgmt/SONiC_YANG_Model_Guidelines.md [sonic-yang-models/tests]: YANG model test code and JSON input for testing. [sonic-yang-models/setup.py]: Build infra for yang models. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
…ment. Changes: Find path of dependencies of os environment. Moving test file in separate dir. sonic-slave-jessie/Dockerfile.j2: Remove ijson pkg. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
praveen-li
force-pushed
the
sonnic-yang-mgmt-msft
branch
from
2f3d185 to
cbe2046
Compare
|
@renukamanavalan @lguohan Kindly review, approve and merge. Thx a lot. |
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
|
retest vsimage please |
1 similar comment
|
retest vsimage please |
added 2 commits
April 13, 2020 12:18
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Changes: 1.) Changing sonic-head to sonic-types. 2.) change prefix from head to stypes. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
|
Resolved all pending comments. Thx |
|
@renukamanavalan , I notice that test passes with last build. I have removed organization names, also have converted sonic-head to sonic-types. Plz let me know if any other comments. Please note for leaf names, I have used this page: https://github.com/Azure/SONiC/wiki/Configuration. Which suggests ACL_RULE, FLEX_COUNTER_TABLE have all leaves in uppercase. Rest tables have all leaves in lower case, but table name is in uppercase. Thx |
lguohan
approved these changes
Apr 14, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sonic-yang-models]: First version of yang models for Port, VLan, Interface, PortChannel, loopback and ACL.
YANG models as per Guidelines.
Guideline doc: https://github.com/Azure/SONiC/blob/master/doc/mgmt/SONiC_YANG_Model_Guidelines.md
[sonic-yang-models/tests]: YANG model test code and JSON input for testing.
[sonic-yang-models/setup.py]: Build infra for yang models.
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
- What I did
Created Yang model for Sonic.
Tables: PORT, VLAN, VLAN_INTERFACE, VLAN_MEMBER, ACL_RULE, ACL_TABLE, INTERFACE.
Created build infra files using which a new package (sonic-yang-models) can be build and can be deployed on sonic switches. Yang models will be part of this new package.
- How I did it
Wrote yang models based on Guideline doc:
https://github.com/Azure/SONiC/blob/master/doc/mgmt/SONiC_YANG_Model_Guidelines.md
and
https://github.com/Azure/SONiC/wiki/Configuration.
Wrote python wheel Package infra which runs test for these Yang models using a json files which consists configuration as per yang models. These configs are for negative tests, which means we want to test that most must condition, pattern and when condition works as expected.
- How to verify it
Build Logs and testing:
———————————————————————————————————
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)