[Services] Restart LLDP service upon unexpected critical process exit. #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
supervisored conf file. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
processes file into dockerfile.j2. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
wants to restart this container more than 3 times in 20 minutes. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
shared Makefile docker-lldp-sv2.mk. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
|
Retest vs please |
lguohan
approved these changes
Nov 6, 2019
jleveque
approved these changes
Nov 6, 2019
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
sonic-net#3713) Signed-off-by: Yong Zhao <yozhao@microsoft.com>
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 9, 2021
sonic-net#3713) Signed-off-by: Yong Zhao <yozhao@microsoft.com> RB=2124908 G=lnos-reviewers R=pchaudha,pmao,vapatil,zxu A=zxu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Restart LLDP service if one of critical processes running in LLDP container exited or crashed abnormally.
How I did it
Generally I follow the framework created by Joe to implement this feature in LLDP container.
First, add supervisor-proc-exit-listener event listener option in Supervisord configuration file in LLDP docker container. Supervisord will read a list of critical processes for which to monitor the unexpected crashed and exited.
Second, configure LLDP.service to always auto-restart the service if it stops, with a delay of 30 seconds. Also set a rate limit of 3 restarts within 20 minutes (1200 seconds).
How to verify it
On your switch device, please use docker ps command to list all running docker containers.
Then use docker exec -it container_id bash to login target container. Typing top command
on the shell will display all the processes dynamically and you will spot the process id of one
of the critical processes. Finally type the command kill -9 process_id to terminate one process.
After exiting the container, you can use watch -n 1 docker ps to dynamically see the restart
of LLDP container.