[Mellanox]Resolve chassis broken due to inconsistent with latest sonic_platform_common #3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 30, 2019 11:47
Currently get_firmware_version implementated by using chassis.get_firmware_version and chassis._component_name_list which are not supported in the latest sonic_platform_common, causing chassis broken. Update this part so that it aligns to the latest sonic_platform_common Support component API
1. rename initialize_components 2. replace cpld?_version with cpld[0-9]_version in order to be more accurate
1. implement file reading by with statment 2. adjust statement which testing whether list is empty
keboliu
approved these changes
Oct 9, 2019
stepanblyschak
approved these changes
Oct 9, 2019
nazariig
approved these changes
Oct 9, 2019
jleveque
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Resolve chassis broken by supporting the latest component API (get_firmware_version)
Currently get_firmware_version implemented by using chassis.get_firmware_version and chassis._component_name_list which are not supported in the latest sonic_platform_common, causing chassis broken.
Update this part so that it aligns to the latest sonic_platform_common
- How I did it
Originally get_firmware_version is a member function of chassis but recently it is moved to component.py. In this case, mlnx-platform-api should be updated accordingly otherwise chassis is broken.
- How to verify it
test
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)