[Mellanox]Upload the SDK makefile modification #3555
Conversation
This doesn't impact the sonic-mellanox image but make the future SDK-integration easier.
|
retest this, please |
platform/mellanox/sdk.mk
Outdated
| $(SX_COMPLIB_DEV) $(SX_COMPLIB_DEV_STATIC) $(SX_EXAMPLES_DEV) \ | ||
| $(SX_GEN_UTILS_DEV) $(SX_SCEW_DEV) $(SX_SCEW_DEV_STATIC) \ | ||
| $(SXD_LIBS_DEV) $(SXD_LIBS_DEV_STATIC) $(WJH_LIBS_DEV) | ||
|
|
There was a problem hiding this comment.
remove extra empty line #Closed
There was a problem hiding this comment.
remove extra empty line
will remove.
| MLNX_SDK_DEBS += $(APPLIBS_DEV) $(IPROUTE2_MLNX_DEV) $(SX_COMPLIB_DEV) \ | ||
| $(SX_COMPLIB_DEV_STATIC) $(SX_EXAMPLES_DEV) $(SX_GEN_UTILS_DEV) \ | ||
| $(SX_SCEW_DEV) $(SX_SCEW_DEV_STATIC) $(SXD_LIBS_DEV)\ | ||
| $(SXD_LIBS_DEV_STATIC) $(WJH_LIBS_DEV) $(SX_ACL_HELPER_DEV) |
There was a problem hiding this comment.
$(SX_ACL_HELPER_DEV [](start = 56, length = 19)
If you can add your new item at a new line and keep old lines, that would be better. #Closed
There was a problem hiding this comment.
I just found that the length of the old lines is uneven and intended to beautify them. It may make it a little difficult to compare changes but only once and I think it is acceptable. Do you mean that?
| # get sources | ||
| rm -rf $(PACKAGE_NAME)-$(MLNX_SDK_VERSION)-$(MLNX_SDK_ISSU_VERSION) | ||
|
|
||
| wget -c $(MLNX_SDK_SOURCE_BASE_URL)/$(PACKAGE_NAME)-$(MLNX_SDK_VERSION)-$(MLNX_SDK_ISSU_VERSION).tar.gz -O - | tar -xz |
There was a problem hiding this comment.
wget -c [](start = 1, length = 7)
maybe curl is easier than wget to get stdout. #Closed
There was a problem hiding this comment.
Hi, since wget works well here, let's keep it as it is.
|
|
||
| popd | ||
|
|
||
| mv $(DERIVED_TARGETS) $* $(DEST)/ |
There was a problem hiding this comment.
$* [](start = 23, length = 2)
Could you explain $*? #Closed
There was a problem hiding this comment.
Hi, it stands for the default deb package. The sx-acl-helper_1.mlnx.4.3.2104_amd64.deb, in this case. #Closed
|
retest vs, please |
|
retest this, please |
- What I did
Adjust the SDK makefiles so that it reflects the dependencies among libraries in SDK 4.3.2104.
This is a supplement of PR [Mellanox]Update SDK(4.3.2104), SAI-Implementation(1.15) and firmware 2162. It doesn't impact the sonic-mellanox.bin image but makes the future SDK-integration easier.
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)