Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[teamd]: Update the start.sh script to clean up the teamd docker state #351

Merged
merged 1 commit into from
Mar 2, 2017
Merged

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented Mar 1, 2017

This change should be temporary because the current teamd cannot
re-create net devices acrosss restart. Basically, it will fail
when there're files in /var/run/teamd/ folder or the previously
created net devices are still there. Thus, the current workaround
is to remove the obsolete files to restart the docker-teamd.

This workaround cannot resolve the swss restart issue. Before
restarting swss, docker teamd needs to be stopped manually. After
swss starts, docker teamd needs to be restarted manually.

This change will only make sure that rebooting the switch will
make the switch at the correct state.

Signed-off-by: Shuotian Cheng shuche@microsoft.com

@lguohan
Copy link
Collaborator

lguohan commented Mar 1, 2017

can you add comment in the code?

@stcheng
Copy link
Contributor Author

stcheng commented Mar 1, 2017

updated

@stcheng stcheng self-assigned this Mar 2, 2017
function start_app {
pkill -9 teamd
pkill -9 teamsyncd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It runs when docker container starts, so no need to pkill?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

This change should be temporary because the current teamd cannot
re-create net devices acrosss restart. Basically, it will fail
when there're files in /var/run/teamd/ folder or the previously
created net devices are still there. Thus, the current workaround
is to remove the obsolete files to restart the docker-teamd.

This workaround cannot resolve the swss restart issue. Before
restarting swss, docker teamd needs to be stopped manually. After
swss starts, docker teamd needs to be restarted manually.

This change will only make sure that rebooting the switch will
make the switch at the correct state.

Signed-off-by: Shuotian Cheng <shuche@microsoft.com>
@stcheng stcheng merged commit f06dc5d into sonic-net:master Mar 2, 2017
@stcheng stcheng deleted the teamd branch March 2, 2017 23:59
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
* ECMP acceleration for physical i/f down events

* ECMP acceleration for physical i/f down events

* ECMP acceleration for physical i/f down events

* ECMP acceleration for physical i/f down events

* add next hop group test

Signed-off-by: Guohan Lu <lguohan@gmail.com>

* reformat the code to align with current style

Signed-off-by: Guohan Lu <lguohan@gmail.com>
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Jun 11, 2020
- Add missed BGP tables into the schema (sonic-net#351)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca added a commit that referenced this pull request Jun 11, 2020
- Add missed BGP tables into the schema (#351)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
abdosi added a commit that referenced this pull request Jun 16, 2020
 Add missed BGP tables into the schema (#351)
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Jun 22, 2020
* 77d3417 2020-06-22 | [sonic-swss-common] ARMHF warning fixes (sonic-net#352) (HEAD -> master, origin/master, origin/HEAD) [arheneus@marvell.com]
* da8e264 2020-06-21 | [python3]: build python3-swsscommon for python3 support (sonic-net#355) [lguohan]
* 292b08a 2020-06-16 | Changes to support SONiC Gearbox Manager (sonic-net#347) [Syd Logan]
* 58ca4d9 2020-06-10 | Add missed BGP tables into the schema (sonic-net#351) [pavel-shirshov]
* cddfc4e 2020-06-09 | [loglevel] Avoid accessing null ptr in swssloglevel (sonic-net#349) [Stephen Sun]
* 8fce898 2020-06-08 | [schema] update schema with rates and utilization table names (sonic-net#330) [Mykola F]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan added a commit that referenced this pull request Jun 23, 2020
* 77d3417 2020-06-22 | [sonic-swss-common] ARMHF warning fixes (#352) (HEAD -> master, origin/master, origin/HEAD) [arheneus@marvell.com]
* da8e264 2020-06-21 | [python3]: build python3-swsscommon for python3 support (#355) [lguohan]
* 292b08a 2020-06-16 | Changes to support SONiC Gearbox Manager (#347) [Syd Logan]
* 58ca4d9 2020-06-10 | Add missed BGP tables into the schema (#351) [pavel-shirshov]
* cddfc4e 2020-06-09 | [loglevel] Avoid accessing null ptr in swssloglevel (#349) [Stephen Sun]
* 8fce898 2020-06-08 | [schema] update schema with rates and utilization table names (#330) [Mykola F]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
yxieca pushed a commit that referenced this pull request Mar 17, 2023
src/sonic-platform-common

* 8460721 - (HEAD -> 202205, origin/202205) Fix issues in cmis.get_transceiver_bulk_status (#351) (10 hours ago) [Stephen Sun]
src/sonic-sairedis

* 10f37ef - (HEAD -> 202205, origin/202205) Ignore removing switch for mellanox platform due to known limitation (#1216) (10 hours ago) [Junchao-Mellanox]
src/sonic-swss

* 5f031af - (HEAD -> 202205, origin/202205) [flowcounterrouter] Fix the Route remove flow for non-bound prefixes (#2691) (10 hours ago) [Vivek]
src/sonic-utilities

* f88ca1c9 - (HEAD -> 202205, origin/202205) Improve show acl commands (#2667) (10 hours ago) [bingwang-ms]
* 738406b7 - Enhance the logic to wait for all buffer tables to be removed in _clear_qos (#2720) (10 hours ago) [Stephen Sun]
How I did it
snider-nokia pushed a commit to snider-nokia/sonic-buildimage that referenced this pull request Apr 6, 2023
* Fix issue in cmis.get_transceiver_bulk_status

1. In case it fails to read EEPROM, either self.get_rx_power() or self.get_tx_power() can be a list of 'N/A'. Need to test it before calling self.mw_to_dbm
2. It should be a valid case for either self.get_rx_power() or self.get_tx_power() to return None. Handle other fields instead of returning None in this case

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Address comments: distinguish scenarios between not supporting and reading failure

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Adjust unit test case

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Remove redundant code

Signed-off-by: Stephen Sun <stephens@nvidia.com>

---------

Signed-off-by: Stephen Sun <stephens@nvidia.com>
mssonicbld added a commit that referenced this pull request Jun 25, 2023
…D automatically (#15609)

#### Why I did it
src/sonic-platform-daemons
```
* 4daa748 - (HEAD -> 202211, origin/202211) PSUD-Delete or update CHASSIS_INFO table PSU/Modules data if added or… (#351) (33 hours ago) [prem-nokia]
```
#### How I did it
#### How to verify it
#### Description for the changelog
yxieca pushed a commit that referenced this pull request Jun 28, 2023
…D automatically (#15610)

src/sonic-platform-daemons

* d24cca4 - (HEAD -> 202205, origin/202205) PSUD-Delete or update CHASSIS_INFO table PSU/Modules data if added or… (#351) (4 days ago) [prem-nokia]
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
…k-18444-and-18704

[YANG]: Add Yang model support for Multi ASIC port and device_metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants