[Mellanox] Fix the typo in mlnx-sfpd #3426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
approved these changes
Sep 10, 2019
lguohan
reviewed
Sep 10, 2019
| @@ -218,7 +218,7 @@ class MlnxSfpd: | |||
|
|
|||
| sfp_state = sfp_value_status_dict.get(module_state, STATUS_UNKNOWN) | |||
| if sfp_state == STATUS_UNKNOWN: | |||
| log_error("unknown module state {} on port {}".format(module_state, port)) | |||
| log_error("unknown module state {} on port(s) {}".format(module_state, port_list)) | |||
There was a problem hiding this comment.
what is the unknown status? it should be either in or out. why is this an error message?
…ng that should be ignored.
sujinmkang
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix the typo in mlnx-sfpd
- How I did it
Fix the typo.
- How to verify it
Inject an error so that the statement can be reached and tested.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)