Create the src archive in target/ when INSTALL_DEBUG_TOOLS=y #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you provide description of the pr, purpose? |
|
retest this please. |
lguohan
approved these changes
Aug 28, 2019
yxieca
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Create the src archive in target/ when INSTALL_DEBUG_TOOLS=y * Dropped -v (verbose flag) from tar command
wangshengjun
pushed a commit
to wangshengjun/sonic-buildimage
that referenced
this pull request
Nov 16, 2020
…et#3323) * Create the src archive in target/ when INSTALL_DEBUG_TOOLS=y * Dropped -v (verbose flag) from tar command
mssonicbld
added a commit
that referenced
this pull request
Oct 15, 2024
…lly (#20499) #### Why I did it src/sonic-swss ``` * b0ed969c - (HEAD -> 202405, origin/202405) Fix portmgr write partial port config to app DB issue. (#3304) (7 hours ago) [Hua Liu] * b4e04631 - Fix port up/bfd sessions bringup notification delay issue. (#3269) (7 hours ago) [Hua Liu] * 7ac0d4fc - Fix the issue where the test case randomly fails due to not waiting after updating the config DB. (#3323) (11 hours ago) [Hua Liu] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Current status
Currently, when debug build is enabled (INSTALL_DEBUG_TOOLS=y), create an archive of all source files that could be handy for debugging are archived into debug image binary. This implies that this archive is accessible only in switches, where this debug image is installed.
- What I did
Create the archive in target/ dir and as well a copy in debug image,
This way, if you are debugging outside the switch, using debug docker only, you have access to corresponding source files (w/o requiring to install debug image).
- How I did it
Updated scripts/dbg_files.sh to create the archive into target/
Update build_debian.sh to pick the archive from target
All the above enabled only if INSTALL_DEBUG_TOOLS=y
- How to verify it
Make a build with INSTALL_DEBUG_TOOLS=y and observe the src archive target/sonic_src.tar.gz
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)