[FRR]: Port some patches from sonic-quagga repo #3017

pavel-shirshov · 2019-06-15T02:14:17Z

Please don't merge it

- What I did
Port 3 patches from sonic-quagga.

- How I did it
Manually

- How to verify it
Build it and run on your dut
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

lguohan · 2019-06-15T19:49:09Z

can you uncomment the invalid_nexthop vs test to make the patch is working?

lguohan

uncomment invalid nexthop vs test please.

pavel-shirshov · 2019-06-17T16:42:44Z

@lguohan Sure. Already did that.

lguohan · 2019-06-17T18:23:50Z

vs test failed. please check. https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-all-pr/85/console

nikos-github · 2019-06-18T20:19:00Z

The nexthop patch is not correct. I have pushed a different version of it a while back into frr latest and I also have diffs to push for the others. The log change needs to be under a cli. Best to hold on to these for a bit until I push into frr the rest of the code. I'm fine after that to push into 7.0 latest and sync to that or commit into sonic-frr but please wait and lets not create patches.

nikos-github

See my comment above.

pavel-shirshov · 2019-06-18T23:17:17Z

@nikos-github Thank you for your comment. I've ported your patch from the master to frr-7.
What do you mean by "The log change needs to be under a cli."?
Thanks

pavel-shirshov · 2019-06-21T00:52:23Z

retest this please

pavel-shirshov · 2019-06-21T21:34:55Z

retest vs please

nikos-github · 2019-06-21T22:48:36Z

@nikos-github Thank you for your comment. I've ported your patch from the master to frr-7.
What do you mean by "The log change needs to be under a cli."?
Thanks

The change from info to debug in vty log needs to go under a cli cmd option. I have that already.

Also the other patch that Guohan pointed me in quagga regarding the dscp, is also not correct and I had pointed that out to him and I have fixed in my diffs.

pavel-shirshov · 2019-06-22T00:28:31Z

@nikos-github
Where can I find your patches?
Thanks

nikos-github · 2019-06-22T04:17:19Z

src/sonic-frr/patch/0004-Allow-BGP-attr-NEXT_HOP-to-be-0.0.0.0-due-to-allevia.patch

+
+ 	/* If NEXT_HOP is present, validate it. */
+ 	if (attr->flag & ATTR_FLAG_BIT(BGP_ATTR_NEXT_HOP)) {
+-		if (attr->nexthop.s_addr == 0


What failure are you seeing with the presence of the previous patch above that's forcing you to make this change?

https://github.com/Azure/sonic-buildimage/blob/master/platform/vs/tests/bgp/test_invalid_nexthop.py to pass the test

@pavel-shirshov @lguohan This isn't the right way to address the case of an IPv6 NLRI being sent and a nexthop attribute of 0. The flag needs to be either cleared or the martian check needs to happen earlier for the relevant AFI/SAFIs. The diffs are just punching a hole in the code but the nexthop attribute flag still remains set. So for AFI/SAFI 1/1 with IPv6 nexthop and also the nexthop attribute present, this is still a problem. Same goes for any AFI/SAFI that is sent along with the 0 nexthop attribute - we will be skipping a valid check.

@nikos-github Currently, when we allow bgpd to have 0.0.0.0 as next-hop ip address, bgpd tries to resolve the next-hop using zebra, zebra responds with the message "unresolved" and this next-hop is not used.
Also, why do you consider that this check was valid? I tried to find in the RFC why NEXT_HOP attribute can't be 0.0.0.0 and I didn't find anything. Probably I miss something. Can you please point me to the place in the RFC which says us we should filter-out next_hops equal to 0.0.0.0?

@paulnice There is no such thing as nexthop of 0.0.0.0 for a prefix learned via a neighbor. Nexthops for prefixes received by peers, correspond to an interface address. 0.0.0.0 is not a valid interface address. It's all described in the RFC.

lguohan · 2019-06-22T21:41:20Z

retest vs please

lguohan · 2019-06-23T00:28:57Z

retest vs please

lguohan · 2019-06-23T04:43:53Z

@pavel-shirshov , tests are still failing.

imzyxwvu · 2020-10-25T06:56:21Z

Hello, could someone tell me what vendor bug is 0004-Allow-BGP-attr-NEXT_HOP-to-be-0.0.0.0-due-to-allevia.patch trying to alleviate. Is there any branded switch sending route update with the Next Hop property value 0.0.0.0?

nikos-github · 2020-10-25T07:04:45Z

Arista.

…lly (#18051) #### Why I did it src/sonic-swss ``` * b18cbac6 - (HEAD -> master, origin/master, origin/HEAD) [Ci] Fix the test script naming issue (#3021) (81 minutes ago) [xumia] * 5fd896f6 - [PortOrch] Add FEC codeword errors in port stats (#3029) (87 minutes ago) [vdahiya12] * 77d56e6e - Fix the Orchagent crash seen during Port channel OC test cases. (#3042) (9 hours ago) [saksarav-nokia] * 4d470592 - Fix memory leak and object copying bugs in orchagent (#3017) (10 hours ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog

…lly (#18141) src/sonic-swss * d322f660 - (HEAD -> 202311, origin/202311) Fix memory leak and object copying bugs in orchagent (#3017) (4 hours ago) [Saikrishna Arcot]

…lly (sonic-net#18051) #### Why I did it src/sonic-swss ``` * b18cbac6 - (HEAD -> master, origin/master, origin/HEAD) [Ci] Fix the test script naming issue (sonic-net#3021) (81 minutes ago) [xumia] * 5fd896f6 - [PortOrch] Add FEC codeword errors in port stats (sonic-net#3029) (87 minutes ago) [vdahiya12] * 77d56e6e - Fix the Orchagent crash seen during Port channel OC test cases. (sonic-net#3042) (9 hours ago) [saksarav-nokia] * 4d470592 - Fix memory leak and object copying bugs in orchagent (sonic-net#3017) (10 hours ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog

pavel-shirshov added 5 commits June 7, 2019 18:44

Update sonic-quagga submodule

ee4613c

Merge branch 'master' of https://github.com/Azure/sonic-buildimage

b12e064

Merge branch 'master' of https://github.com/Azure/sonic-buildimage

b562508

Merge branch 'master' of https://github.com/Azure/sonic-buildimage

11c2f0c

Port some patches from sonic-quagga

8aaee9a

pavel-shirshov added the Enhancement ➕ label Jun 15, 2019

pavel-shirshov requested a review from lguohan June 15, 2019 02:14

pavel-shirshov self-assigned this Jun 15, 2019

pavel-shirshov added 2 commits June 14, 2019 22:36

Fix Makefile

a82060f

Another patch

b734609

lguohan requested changes Jun 15, 2019

View reviewed changes

Uncomment bgp test

eb434db

nikos-github suggested changes Jun 18, 2019

View reviewed changes

Downport Nikos's patch

69f81fc

Add a patch to alleviate the vendor issue

80e6322

nikos-github suggested changes Jun 22, 2019

View reviewed changes

use patch instead of stg

d62e0ff

lguohan approved these changes Jun 23, 2019

View reviewed changes

pavel-shirshov merged commit dd0f005 into sonic-net:master Jun 23, 2019

pavel-shirshov deleted the pavelsh/frr_patches branch June 23, 2019 22:26

gpaussabrcm mentioned this pull request Sep 4, 2019

Error rebuilding FRR after clean #3407

Closed

pavel-shirshov mentioned this pull request Sep 25, 2019

[FRR]: Use stg instead of patch #3480

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FRR]: Port some patches from sonic-quagga repo #3017

[FRR]: Port some patches from sonic-quagga repo #3017

pavel-shirshov commented Jun 15, 2019 •

edited

Loading

lguohan commented Jun 15, 2019

lguohan left a comment

pavel-shirshov commented Jun 17, 2019

lguohan commented Jun 17, 2019

nikos-github commented Jun 18, 2019 •

edited

Loading

nikos-github left a comment •

edited

Loading

pavel-shirshov commented Jun 18, 2019

pavel-shirshov commented Jun 21, 2019

pavel-shirshov commented Jun 21, 2019

nikos-github commented Jun 21, 2019

pavel-shirshov commented Jun 22, 2019

nikos-github Jun 22, 2019

pavel-shirshov Jun 23, 2019

nikos-github Jun 24, 2019 •

edited

Loading

paulnice Jun 25, 2019

nikos-github Jun 25, 2019

lguohan commented Jun 22, 2019

lguohan commented Jun 23, 2019

lguohan commented Jun 23, 2019

imzyxwvu commented Oct 25, 2020

nikos-github commented Oct 25, 2020

[FRR]: Port some patches from sonic-quagga repo #3017

[FRR]: Port some patches from sonic-quagga repo #3017

Conversation

pavel-shirshov commented Jun 15, 2019 • edited Loading

lguohan commented Jun 15, 2019

lguohan left a comment

Choose a reason for hiding this comment

pavel-shirshov commented Jun 17, 2019

lguohan commented Jun 17, 2019

nikos-github commented Jun 18, 2019 • edited Loading

nikos-github left a comment • edited Loading

Choose a reason for hiding this comment

pavel-shirshov commented Jun 18, 2019

pavel-shirshov commented Jun 21, 2019

pavel-shirshov commented Jun 21, 2019

nikos-github commented Jun 21, 2019

pavel-shirshov commented Jun 22, 2019

nikos-github Jun 22, 2019

Choose a reason for hiding this comment

pavel-shirshov Jun 23, 2019

Choose a reason for hiding this comment

nikos-github Jun 24, 2019 • edited Loading

Choose a reason for hiding this comment

paulnice Jun 25, 2019

Choose a reason for hiding this comment

nikos-github Jun 25, 2019

Choose a reason for hiding this comment

lguohan commented Jun 22, 2019

lguohan commented Jun 23, 2019

lguohan commented Jun 23, 2019

imzyxwvu commented Oct 25, 2020

nikos-github commented Oct 25, 2020

pavel-shirshov commented Jun 15, 2019 •

edited

Loading

nikos-github commented Jun 18, 2019 •

edited

Loading

nikos-github left a comment •

edited

Loading

nikos-github Jun 24, 2019 •

edited

Loading