[zebra.conf] Avoid zebra crash upon empty configuration #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
approved these changes
Oct 26, 2018
6 tasks
prsunny
pushed a commit
that referenced
this pull request
Mar 30, 2022
* [202012] - sonic-swss submodule update to include following commits: fca407a (HEAD) [VNET]Fixing nexthop group delete during route change (#2198) a9b6b47 [vxlan] Remove tunnel map objects on VNET tunnel removal (#2208) 74e9b9f [FdbOrch] SAI_FDB_EVENT_MOVE generates update with empty update.entry.port_name (#2201) 0a99445 [202012][BFD]Registering BFD state change callback during session creation (#2203) aebe4a1 [VS test] skip dpb flaky test (#2195) (#2207)
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Current zebra.conf template will generate an invalid configuration file and crash zebra process, when no ipv4 loopback address is defined. Though this will not happen during normal use case, it could cause unexpected zebra crash log when applying 'empty' preset configurations. This change intends to fix this problem.
- How I did it
Add check in zebra.conf template similar to what we are doing for ipv6 loopback addresses