Add BMP to init config in default disabled state #21863
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
| @@ -67,7 +67,8 @@ | |||
| ("pmon", "enabled", "{% if 'type' in DEVICE_METADATA['localhost'] and DEVICE_METADATA['localhost']['type'] == 'SpineRouter' %}False{% else %}True{% endif %}", "enabled"), | |||
| ("snmp", "enabled", true, "enabled"), | |||
| ("swss", "enabled", false, "enabled"), | |||
| ("syncd", "enabled", false, "enabled")] %} | |||
| ("syncd", "enabled", false, "enabled"), | |||
| ("bmp", "disabled", "False", "enabled")] %} | |||
There was a problem hiding this comment.
Shouldn't we move to golden config, instead of init_cfg.json change in the future? @qiluo-msft
There was a problem hiding this comment.
As far as I understand, golden config is not an alternative to init_cfg. https://github.com/sonic-net/sonic-mgmt/blob/master/ansible/library/generate_golden_config_db.py
It possibly just keeps track of last known sane config in sonic-mgmt. (the one put by deploy-mg)
I understand ini_cfg.json.j2 is protected and we want to exercise discretion while updating it but I believe this change is necessary. In case I am missing something please point me to the appropriate file where I should put this.
StormLiangMS
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Mar 6, 2025
What is the motivation for this PR? bmp/test_bmp_statedb.py and bmp/test_docker_restart.py are failing as they try to test BMP without enabling it. How did you do it? Created a fixture to enable BMP. For the CLI to work we also need: sonic-net/sonic-buildimage#21863 How did you verify/test it? Ran all tests in the BMP directory.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 6, 2025
What is the motivation for this PR? bmp/test_bmp_statedb.py and bmp/test_docker_restart.py are failing as they try to test BMP without enabling it. How did you do it? Created a fixture to enable BMP. For the CLI to work we also need: sonic-net/sonic-buildimage#21863 How did you verify/test it? Ran all tests in the BMP directory.
11 tasks
mssonicbld
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Mar 11, 2025
What is the motivation for this PR? bmp/test_bmp_statedb.py and bmp/test_docker_restart.py are failing as they try to test BMP without enabling it. How did you do it? Created a fixture to enable BMP. For the CLI to work we also need: sonic-net/sonic-buildimage#21863 How did you verify/test it? Ran all tests in the BMP directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The new feature was introduced in the this set of pull requests: sonic-net/SONiC#1621
This feature runs inside a new docker container. In order to enable it through CLI
sudo config feature stateit should be a part of base config orinit_cfg.jsonat/etc/sonic.Some sonic-mgmt tests were added in sonic-net/sonic-mgmt#15749 which are currently failing in full test suite runs. We need this so that we can enable BMP while running them.
Work item tracking
#459
How I did it
Update
files/build_templates/init_cfg.json.j2How to verify it
Ran all BMP sonic-mgmt tests with changes in this PR as well as sonic-net/sonic-mgmt#17179.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)