Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 25G profiles for Seastone platform #2157

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Add 25G profiles for Seastone platform #2157

merged 1 commit into from
Oct 16, 2018

Conversation

zhenggen-xu
Copy link
Collaborator

@zhenggen-xu zhenggen-xu commented Oct 15, 2018 •
edited by lguohan
Loading

- What I did
Add 96x25 + 16x50G profile for Seastone platform

- How I did it
Add 96x25 + 16x50G profile for Seastone platform

- How to verify it
Build image. Then:

$  sonic-cfggen -H -k Seastone-DX010-25-50 --preset t1 > config_db.json.25g
$  sudo config reload config_db.json.25g -y
Running command: systemctl stop dhcp_relay
Running command: systemctl stop swss
Running command: systemctl stop snmp
Warning: Stopping snmp.service, but it can still be activated by:
  snmp.timer
Running command: systemctl stop lldp
Running command: systemctl stop pmon
Running command: systemctl stop bgp
Running command: systemctl stop teamd
Running command: sonic-cfggen -j config_db.json.25g --write-to-db
Running command: systemctl restart hostname-config
Running command: systemctl restart interfaces-config
Running command: systemctl restart ntp-config
Running command: systemctl restart rsyslog-config
Running command: systemctl restart swss
Running command: systemctl restart bgp
Running command: systemctl restart teamd
Running command: systemctl restart pmon
Running command: systemctl restart lldp
Running command: systemctl restart snmp
Running command: systemctl restart dhcp_relay

admin@sonic:~$ show interfaces status 
  Interface    Lanes    Speed    MTU    Alias    Oper    Admin
  -----------  -------  -------  -----  -------  ------  -------
  Ethernet0       65      25G   9100   Eth1/1    down       up
  Ethernet1       66      25G   9100   Eth1/2    down       up
  Ethernet2       67      25G   9100   Eth1/3    down       up
  Ethernet3       68      25G   9100   Eth1/4    down       up
  Ethernet4       69      25G   9100   Eth2/1    down       up
  Ethernet5       70      25G   9100   Eth2/2    down       up
  Ethernet6       71      25G   9100   Eth2/3    down       up
  Ethernet7       72      25G   9100   Eth2/4    down       up
  Ethernet8       73      25G   9100   Eth3/1    down       up
  Ethernet9       74      25G   9100   Eth3/2    down       up
 Ethernet10       75      25G   9100   Eth3/3    down       up
 Ethernet11       76      25G   9100   Eth3/4    down       up
 Ethernet12       77      25G   9100   Eth4/1    down       up
 Ethernet13       78      25G   9100   Eth4/2    down       up
 Ethernet14       79      25G   9100   Eth4/3    down       up
 Ethernet15       80      25G   9100   Eth4/4    down       up
 Ethernet16       33      25G   9100   Eth5/1    down       up
 Ethernet17       34      25G   9100   Eth5/2    down       up
 Ethernet18       35      25G   9100   Eth5/3    down       up
 Ethernet19       36      25G   9100   Eth5/4    down       up
 Ethernet20       37      25G   9100   Eth6/1    down       up
 Ethernet21       38      25G   9100   Eth6/2    down       up
 Ethernet22       39      25G   9100   Eth6/3    down       up
 Ethernet23       40      25G   9100   Eth6/4    down       up
 Ethernet24       41      25G   9100   Eth7/1    down       up
 Ethernet25       42      25G   9100   Eth7/2    down       up
 Ethernet26       43      25G   9100   Eth7/3    down       up
 Ethernet27       44      25G   9100   Eth7/4    down       up
 Ethernet28       45      25G   9100   Eth8/1    down       up
 Ethernet29       46      25G   9100   Eth8/2    down       up
 Ethernet30       47      25G   9100   Eth8/3    down       up
 Ethernet31       48      25G   9100   Eth8/4    down       up
 Ethernet32       49      25G   9100   Eth9/1      up       up
 Ethernet33       50      25G   9100   Eth9/2      up       up
 Ethernet34       51      25G   9100   Eth9/3      up       up
 Ethernet35       52      25G   9100   Eth9/4      up       up
 Ethernet36       53      25G   9100  Eth10/1      up       up
 Ethernet37       54      25G   9100  Eth10/2      up       up
 Ethernet38       55      25G   9100  Eth10/3      up       up
 Ethernet39       56      25G   9100  Eth10/4      up       up

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

nikos-github
nikos-github reviewed Oct 16, 2018
View reviewed changes
Copy link
Collaborator

@nikos-github nikos-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought all minigraphs were removed. These are the only ones remaining:

./device/quanta/x86_64-quanta_ix1b_rglbmc-r0/minigraph.xml
./device/inventec/x86_64-inventec_d6254qs-r0/minigraph.xml
./device/inventec/x86_64-inventec_d6556-r0/minigraph.xml
./device/celestica/x86_64-cel_seastone-r0/Seastone-DX010/minigraph.xml
./device/celestica/x86_64-cel_seastone-r0/Seastone-DX010-50/minigraph.xml
./device/celestica/x86_64-cel_seastone-r0/Seastone-DX010-10-50/minigraph.xml

Are they needed for seastone?

@zhenggen-xu
Copy link
Collaborator Author

I don't think they are required. I can remove all the minigraph files after more testing. Maybe in a different PR.

@lguohan
Copy link
Collaborator

lguohan commented Oct 16, 2018

no need minigraph now.

lguohan
lguohan reviewed Oct 16, 2018
View reviewed changes
...stica/x86_64-cel_seastone-r0/Seastone-DX010-25-50/th-seastone-dx010-96x25G-16x50G.config.bcm
phy_xaui_tx_polarity_flip_130=0x0002
phy_xaui_rx_polarity_flip_130=0x0000
phy_xaui_tx_polarity_flip_131=0x0001
phy_xaui_rx_polarity_flip_131=0x0000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no serdes settings?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default worked for our cable length. For different cable lengths, we should use bcmcmd or SAI APIs to change the settings dynamically.

@lguohan lguohan merged commit 5f2b1a7 into sonic-net:master Oct 16, 2018
@zhenggen-xu zhenggen-xu deleted the 25g-profile branch June 7, 2019 19:33
dprital added a commit to dprital/sonic-buildimage that referenced this pull request May 25, 2022
@dprital
[submodule] Update sonic-utilities submodule
657dd81 
Update sonic-utilities submodule pointer to include the following:
* [GCU] Handling type1 lists ([sonic-net#2171](sonic-net/sonic-utilities#2171))
* [yang] extend ConfigMgmt constructor to pass YANG options ([sonic-net#2118](sonic-net/sonic-utilities#2118))
* [dump] implement ACL modules ([sonic-net#2153](sonic-net/sonic-utilities#2153))
* show commands for SYSTEM READY ([sonic-net#1851](sonic-net/sonic-utilities#1851))
* [GCU] Handling non-compliant leaf-list with string values ([sonic-net#2174](sonic-net/sonic-utilities#2174))
* Add sonic-delayed.target to Application Extension .timer file generator ([sonic-net#2176](sonic-net/sonic-utilities#2176))
* [portconfig] Allow to configure interface mtu for physical ports ([#l](https://github.com/Azure/sonic-utilities/pull/l))
* Broadcast Unknown-multicast and Unknown-unicast Storm-control  ([sonic-net#928](sonic-net/sonic-utilities#928))
* sonic-utils: initial support for link-training ([sonic-net#2071](sonic-net/sonic-utilities#2071))
* [portchannel] Added ACL/PBH binding checks to the port before getting added to portchannel ([sonic-net#2151](sonic-net/sonic-utilities#2151))
* Modify override testcase to cover PORT admin_status ([sonic-net#2165](sonic-net/sonic-utilities#2165))
* [GCU] Validate peer_group_range ip_range are correct ([sonic-net#2145](sonic-net/sonic-utilities#2145))
* [auto-ts] add memory check ([sonic-net#2116](sonic-net/sonic-utilities#2116))
* support new interface types CR8/SR8/KR8/LR8 which are brougnt by SAI V.1.10.2 ([sonic-net#2167](sonic-net/sonic-utilities#2167))
* [scripts/fast-reboot] Add option to include ssd-upgrader-part boot option with SONiC partition ([sonic-net#2150](sonic-net/sonic-utilities#2150))
* [config reload] Fix invalid rstrip. ([sonic-net#2157](sonic-net/sonic-utilities#2157))
* Accept 0 for queue and dscp ([sonic-net#2162](sonic-net/sonic-utilities#2162))

Signed-off-by: dprital <drorp@nvidia.com>
@ayurkiv-nvda ayurkiv-nvda mentioned this pull request May 26, 2022
Closed
6 tasks
stepanblyschak added a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 27, 2022
@stepanblyschak
[sonic-utilities] update submodule
18b1a5a 
```
3d3c89b fix for non-coherent cmis modules (sonic-net#2163)
2054680 [subinterface] Fix route add command to accept subinterface as dev (sonic-net#2180)
5383e92 [subinterface]Avoid removing the subinterface when last configured ip is removed (sonic-net#2181)
f5af780 [GCU] Handling type1 lists (sonic-net#2171)
4516179 [yang] extend ConfigMgmt constructor to pass YANG options (sonic-net#2118)
2f53bd4 [dump] implement ACL modules (sonic-net#2153)
494dd62 show commands for SYSTEM READY (sonic-net#1851)
4fc09b1 [GCU] Handling non-compliant leaf-list with string values (sonic-net#2174)
675c7b6 Add sonic-delayed.target to Application Extension .timer file generator (sonic-net#2176)
c587933 [portconfig] Allow to configure interface mtu for physical ports only
9881f3e Broadcast Unknown-multicast and Unknown-unicast Storm-control  (sonic-net#928)
88286cb sonic-utils: initial support for link-training (sonic-net#2071)
29503ab [portchannel] Added ACL/PBH binding checks to the port before getting added to portchannel (sonic-net#2151)
ac89489 Modify override testcase to cover PORT admin_status (sonic-net#2165)
d7953d2 [GCU] Validate peer_group_range ip_range are correct (sonic-net#2145)
aa81b97 [auto-ts] add memory check (sonic-net#2116)
b370290 support new interface types CR8/SR8/KR8/LR8 which are brougnt by SAI V.1.10.2 (sonic-net#2167)
87fc0a4 [scripts/fast-reboot] Add option to include ssd-upgrader-part boot option with SONiC partition (sonic-net#2150)
90abc07 [config reload] Fix invalid rstrip. (sonic-net#2157)
fac1769 Accept 0 for queue and dscp (sonic-net#2162)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
wen587 added a commit that referenced this pull request Jun 13, 2022
@wen587
[sonic-utilities] update submodule (#11090)
6a4105a 
29503ab [portchannel] Added ACL/PBH binding checks to the port before getting added to portchannel (#2151)
ac89489 Modify override testcase to cover PORT admin_status (#2165)
d7953d2 [GCU] Validate peer_group_range ip_range are correct (#2145)
aa81b97 [auto-ts] add memory check (#2116)
b370290 support new interface types CR8/SR8/KR8/LR8 which are brougnt by SAI V.1.10.2 (#2167)
87fc0a4 [scripts/fast-reboot] Add option to include ssd-upgrader-part boot option with SONiC partition (#2150)
90abc07 [config reload] Fix invalid rstrip. (#2157)
fac1769 Accept 0 for queue and dscp (#2162)
@aravindmani-1 aravindmani-1 mentioned this pull request Nov 18, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan left review comments

@nikos-github nikos-github nikos-github left review comments

Assignees
No one assigned
Labels
Enhancement ➕ Platform: Celestica
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhenggen-xu @lguohan @nikos-github @stcheng