Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support yang model for bulk size per counter #21266

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Support yang model for bulk size per counter #21266

merged 1 commit into from
Feb 13, 2025

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Dec 23, 2024 •
edited
Loading

Why I did it

Support yang model for bulk size per counter

HLD: sonic-net/SONiC#1864

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@stephenxs
Support yang model for bulk size per prefix
168770c 
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs changed the title Support yang model for bulk size per prefix Support yang model for bulk size per counter Dec 23, 2024
@stephenxs stephenxs mentioned this pull request Dec 23, 2024
Merged
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

@qiluo-msft can you please approve and merge?

stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request Jan 27, 2025
@dgsudharsan
[202412_RC]Support yang model for bulk size per counter sonic-net#21266
f45c9ce
@liat-grozovik
Copy link
Collaborator

@dgsudharsan @qiluo-msft any further comments on yang PR? if not, i will merge.

@stephenxs
Copy link
Collaborator Author

@liat-grozovik @qiluo-msft could you help to merge the PR? thanks

@qiluo-msft qiluo-msft requested review from wen587 and ganglyu February 12, 2025 23:41
wen587
wen587 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@wen587 wen587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qiluo-msft qiluo-msft merged commit 360d425 into sonic-net:master Feb 13, 2025
22 checks passed
@stephenxs stephenxs deleted the bulk-chunk-size-per-counter-yang branch February 13, 2025 02:40
@r12f
Copy link
Contributor

r12f commented Feb 14, 2025

hi @stephenxs , do you mind to help resolve this conflict for 202411?

@stephenxs
Copy link
Collaborator Author

202411

Hi @r12f
I see it can be cherry-picked to 202411 cleanly. The flag Cherry-pick 202411_conflict was added 1.5 months ago maybe because some dependencies hadn't been cherry-picked.
Should I remove the flag?

stephens@f3c9307d9ba1:/sonic/src$ git cherry-pick 360d425bff0af951206d0f4474fc7def3aa8d728
[detached HEAD 65b1bdc154] Support yang model for bulk size per prefix (#21266)
 Author: Stephen Sun <5379172+stephenxs@users.noreply.github.com>
 Date: Thu Feb 13 10:58:45 2025 +0900
 2 files changed, 24 insertions(+)
stephens@f3c9307d9ba1:/sonic/src$ git log
commit 65b1bdc154df86fc124e01854b21207a9c02ae9c (HEAD)
Author: Stephen Sun <5379172+stephenxs@users.noreply.github.com>
Date:   Thu Feb 13 10:58:45 2025 +0900

    Support yang model for bulk size per prefix (#21266)
    
    Why I did it
    Support yang model for bulk size per counter
    
    HLD: sonic-net/SONiC#1864

commit 13c2228a9ee4507652197e4c6f467b5266a8776e (origin/202411)
Author: mssonicbld <79238446+mssonicbld@users.noreply.github.com>
Date:   Fri Feb 14 10:01:39 2025 +0800

    [submodule] Update submodule sonic-platform-common to the latest HEAD automatically (#21728)
    
    #### Why I did it
    src/sonic-platform-common
    ```
    * c735073 - (HEAD -> 202411, origin/202411) [202411][cmis] Fix cmis.get_error_description speed for passive module (#538) (13 hours ago) [Aryeh Feigin]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog

@r12f
Copy link
Contributor

r12f commented Feb 18, 2025

thanks @stephenxs !

hi @kperumalbfn - do you mind to help check and approve this PR?

@mssonicbld mssonicbld mentioned this pull request Feb 19, 2025
Merged
11 tasks
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #21783

prabhataravind pushed a commit to prabhataravind/sonic-buildimage that referenced this pull request Mar 5, 2025
@stephenxs @prabhataravind
Support yang model for bulk size per prefix (sonic-net#21266)
b5f3877 
Why I did it
Support yang model for bulk size per counter

HLD: sonic-net/SONiC#1864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wen587 wen587 wen587 approved these changes

@dgsudharsan dgsudharsan dgsudharsan approved these changes

@kcudnik kcudnik kcudnik approved these changes

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@ganglyu ganglyu ganglyu approved these changes

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

Assignees
No one assigned
Labels
Approved for 202411 Branch Included in 202411 Branch Request for 202411 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@stephenxs @mssonicbld @liat-grozovik @r12f @wen587 @dgsudharsan @kcudnik @ganglyu @qiluo-msft @kperumalbfn