Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bfn sde dep #2086

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Fix bfn sde dep #2086

merged 1 commit into from
Sep 27, 2018

Conversation

mkbalani
Copy link
Contributor

- What I did
Fixed sonic build for Barefoot platforms

- How I did it
Added missing dependency/library to syncd image

- How to verify it
Build sonic image for barefoot platforms

- Description for the changelog
Modified bfn syncd docker files

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Sep 27, 2018

retest this please

1 similar comment
@lguohan
Copy link
Collaborator

lguohan commented Sep 27, 2018

retest this please

@lguohan lguohan merged commit 2ffbb0e into sonic-net:201807 Sep 27, 2018
stephenxs added a commit to stephenxs/sonic-buildimage that referenced this pull request Dec 22, 2021
691c37b [Route bulk] Fix bugs in case a SET operation follows a DEL operation in the same bulk (sonic-net#2086)
a4c80c3 patch for issue sonic-net#1971 - enable Rx Drop handling for cisco-8000 (sonic-net#2041)
71751d1 [macsec] Support setting IPG by gearbox_config.json (sonic-net#2051)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
… in the same bulk (sonic-net#2086)

**What I did**

Fix 2 issues in route bulk operation in the scenario where a SET operation follows a DEL operation on the same prefix.
1. The route entry SET operation can be ignored if it follows a DEL operation with the same prefix and next-hop.
2. DEL and then SET default route results in orchagent aborted

Added test case to cover the scenarios

**How I verified it**

Manually test
Unit test

**Details if related**
***The route entry SET operation can be ignored if it follows a DEL operation with the same prefix and next-hop.***
For example, the following operations
```
2021-12-18.06:17:54.793234|ROUTE_TABLE:1.1.1.0/24|SET|nexthop:10.0.0.33|ifname:Ethernet64
2021-12-18.06:19:53.187294|ROUTE_TABLE:1.1.1.0/24|DEL
2021-12-18.06:20:10.279850|ROUTE_TABLE:1.1.1.0/24|SET|nexthop:10.0.0.33|ifname:Ethernet64
```
result in the next sai operations
```
2021-12-18.06:19:31.203092|C|SAI_OBJECT_TYPE_ROUTE_ENTRY||{"dest":"1.1.1.0/24","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000010"}|SAI_ROUTE_ENTRY_ATTR_NEXT_HOP_ID=oid:0x4000000000aae
2021-12-18.06:20:23.813475|R|SAI_OBJECT_TYPE_ROUTE_ENTRY||{"dest":"1.1.1.0/24","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000010"}
```
and the last SET is lost.

This is because:
Both DEL and the 2nd SET operations were bundled into bulk operations.
There is a logic that is not to program ASIC if the next-hop information in the route entry update isn't changed,
which is done by comparing the next-hop information between route entry update and m_syncdRoutes.
However, in bulk mode, a route entry that will be removed will not be removed from m_syncdRoutes until the bulk is flushed,
The bulk has not been flushed when the 2nd SET is handled,
which means the comparison returns "not changed" and the 2nd SET operation is ignored.

The fix is to check whether the prefix is in gRouteBulker.removing_entries and treat it as non-exist if yes.

***DEL and then SET default route results in orchagent aborted***

This is because:
1. packet forward action is initialized when route entry is created
2. the default route will be set to DROP if the application asks for removing it
3. if the default route is readded later in the same bulk session,
   it doesn't update packet forward action but provides a valid next-hop
4. SAI complains if both DROP and a valid next hop are provided

Solution:
Always set packet action for the default route
liorghub added a commit to liorghub/sonic-buildimage that referenced this pull request Mar 23, 2022
Update sonic-utilities submodule to include below commits:
510a9b9 Add date to show version (sonic-net#2086)
61b1396 [sfpshow][recycle_port] sfpshow script needs to skip recycle ports (sonic-net#2109)
4681697 Support command `show ip fib` and `show ipv6 fib` (sonic-net#2100)
2a982a1 Update `config mirror_session` CLI to support heximal gre type value (sonic-net#2095)
b25f1e1 [generic-config-updater] Add caclrule validator (sonic-net#2103)
968900c [sonic-package-manager] do not mod_config for whole config db when setting init_cfg (sonic-net#2055)
bf55ceb [nvgre] Added auto-generated CLI plugins and test for NVGRE Tunnel feature (sonic-net#1915)
liat-grozovik pushed a commit that referenced this pull request Mar 30, 2022
Update sonic-utilities submodule to include below commits:
510a9b9 Add date to show version (#2086)
61b1396 [sfpshow][recycle_port] sfpshow script needs to skip recycle ports (#2109)
4681697 Support command `show ip fib` and `show ipv6 fib` (#2100)
2a982a1 Update `config mirror_session` CLI to support heximal gre type value (#2095)
b25f1e1 [generic-config-updater] Add caclrule validator (#2103)
968900c [sonic-package-manager] do not mod_config for whole config db when setting init_cfg (#2055)
bf55ceb [nvgre] Added auto-generated CLI plugins and test for NVGRE Tunnel feature (#1915)
8389c81 [sonic-cli-gen] fix failure "Error: digits_class" when field "digit_class" does not exist in DB (#2054)
f71ef64 Fix import statement in mclag.py (#2073)
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
- What I did
Add the current date attribute to the "show version" output that includes the current date and hour on the switch.

- How I did it
In sonic-utilities, in the "version" subcommand, print of the current date will be added using "datetime" from the "datetime" library.

- How to verify it
Execute "show version" command and verify "Date" row under the "Uptime" row.

Signed-off-by: EdenGri <eden7045@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants