[aboot] add SWI_DEFAULT support in boot0 #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently setting the next boot image is the same as setting a default image. With this change SWI_DEFAULT= will be considered the default image and SWI= the next image. When executing the boot0 SWI= will be overriden by SWI_DEFAULT= if it exists and create in with the value of SWI= otherwise.
yxieca
approved these changes
Sep 19, 2018
5 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
Feb 1, 2022
53c630b [CoPP] Add always_enabled field to coppmgr logic ([minigraph]: Add PORTCHANNEL_MEMBER configurations #2034) adcf69d [cbf] Fix cbf sync error ([aboot] add SWI_DEFAULT support in boot0 #2056) 69f9ee5 fix mclagsyncd out of order initialization ([submodules] update dbsyncd and snmpagent pointers for LLDP MIB support #2112)
Ndancejic
pushed a commit
to Ndancejic/sonic-buildimage
that referenced
this pull request
May 3, 2022
What I did Changed the CBF group members sync code to be non-assertive when one of its members is not yet synced. Why I did it There can be situations when the member of a CBF group is not yet synced by the time the CBF group is being synced. Some examples would be: CBF group entry is created before its member in APPL_DB Member sync is being blocked by something, like missing a neighbor/NH entry In this scenarios, we should wait for the member to be synced instead of asserting as the member might become available shortly. How I verified it Added a new UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Currently setting the next boot image is the same as setting a default image.
With this change SWI_DEFAULT= will be considered the default image and SWI= the next image.
When executing the boot0 SWI= will be overriden by SWI_DEFAULT= if it
exists and create in with the value of SWI= otherwise.
- How to verify it
The code from sonic-net/sonic-utilities#323 is needed for CLI support.
However the boot-config file can still be crafted by manually setting SWI= and SWI_DEFAULT=