Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VOQ Chassis] Reduce the i-BGP Keep alive and Hold timer value #20189

Merged
merged 36 commits into from
Sep 9, 2024

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Sep 7, 2024

What I did:

Reduce the i-BGP Keep alive and Hold timer value for i-BGP session in VOQ Chassis
ADO: 28758148

Why I did:

In case on upgraceful reboot of LC's faster BGP convergance.

How I verify:
Manual Verification
UT updated.

abdosi and others added 30 commits August 3, 2023 04:47
peer device's

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
higher value so that BGP learnt default route is higher priority.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
save as `slice_type` as part of DEVICE_METADATA

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
 save as `slice_type` as part of DEVICE_METADATA for Chassis Device type

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
pmon need to enable asap to detect ASIC's on Supervisor.
pmonm need to enable asap for bring-up of 400G ports on LC's fast
becuase of CMIS state machine present in PMON.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Inband and Recirc Port was not done correctlly. Also fixed the UT

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
in VOQ Chassis

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@abdosi abdosi added the Chassis for 202205 branch PRs needed for 202205 branch in msft repo label Sep 7, 2024
@abdosi
Copy link
Contributor Author

abdosi commented Sep 9, 2024

@rlhui : Can you please help with merge of this.

@rlhui rlhui merged commit c883f16 into sonic-net:master Sep 9, 2024
23 checks passed
@abdosi
Copy link
Contributor Author

abdosi commented Sep 11, 2024

@gechiang : please help in taking MSFT repo.

@rlhui
Copy link
Contributor

rlhui commented Sep 11, 2024

@BYGX-wcr

@BYGX-wcr
Copy link

@BYGX-wcr

Got this

@BYGX-wcr BYGX-wcr added the Included in Chassis for 202205 Branch Indicate PR is already in MSFT repo 202205 branch label Sep 11, 2024
vvolam pushed a commit to vvolam/sonic-buildimage that referenced this pull request Sep 12, 2024
…-net#20189)

* Change the Hold timer to 7 sec and Keep alive to 2 sec for i-BGP session
in VOQ Chassis

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@abdosi
Copy link
Contributor Author

abdosi commented Sep 18, 2024

@bingwang-ms @yejianquan : please help with cherry-pick.

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 19, 2024
…-net#20189)

* Change the Hold timer to 7 sec and Keep alive to 2 sec for i-BGP session
in VOQ Chassis

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #20298

mssonicbld pushed a commit that referenced this pull request Sep 19, 2024
* Change the Hold timer to 7 sec and Keep alive to 2 sec for i-BGP session
in VOQ Chassis

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants