-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VOQ Chassis] Reduce the i-BGP Keep alive and Hold timer value #20189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peer device's Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
higher value so that BGP learnt default route is higher priority. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
save as `slice_type` as part of DEVICE_METADATA Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
…graph and" This reverts commit 0f2d26d.
save as `slice_type` as part of DEVICE_METADATA for Chassis Device type Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
pmon need to enable asap to detect ASIC's on Supervisor. pmonm need to enable asap for bring-up of 400G ports on LC's fast becuase of CMIS state machine present in PMON. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Inband and Recirc Port was not done correctlly. Also fixed the UT Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
in VOQ Chassis Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
abdosi
added
the
Chassis for 202205 branch
PRs needed for 202205 branch in msft repo
label
Sep 7, 2024
arlakshm
approved these changes
Sep 7, 2024
judyjoseph
approved these changes
Sep 8, 2024
@rlhui : Can you please help with merge of this. |
@gechiang : please help in taking MSFT repo. |
Got this |
10 tasks
BYGX-wcr
added
the
Included in Chassis for 202205 Branch
Indicate PR is already in MSFT repo 202205 branch
label
Sep 11, 2024
vvolam
pushed a commit
to vvolam/sonic-buildimage
that referenced
this pull request
Sep 12, 2024
…-net#20189) * Change the Hold timer to 7 sec and Keep alive to 2 sec for i-BGP session in VOQ Chassis Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@bingwang-ms @yejianquan : please help with cherry-pick. |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 19, 2024
…-net#20189) * Change the Hold timer to 7 sec and Keep alive to 2 sec for i-BGP session in VOQ Chassis Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Cherry-pick PR to 202405: #20298 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Change the Hold timer to 7 sec and Keep alive to 2 sec for i-BGP session in VOQ Chassis Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved for 202405 Branch
Chassis for 202205 branch
PRs needed for 202205 branch in msft repo
Included in Chassis for 202205 Branch
Indicate PR is already in MSFT repo 202205 branch
Included in 202405 Branch
Request for 202405 Branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Reduce the i-BGP Keep alive and Hold timer value for i-BGP session in VOQ Chassis
ADO: 28758148
Why I did:
In case on upgraceful reboot of LC's faster BGP convergance.
How I verify:
Manual Verification
UT updated.