[chassis] add condition is yang model to make lanes not mandatory for chassis #19968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlakshm
requested review from
abdosi,
xincunli-sonic,
qiluo-msft and
ganglyu
and removed request for
qiluo-msft
ganglyu
reviewed
Aug 21, 2024
ganglyu
reviewed
Sep 4, 2024
|
Hi @arlakshm , could you check the failure of checker? |
|
I confirmed that this PR fixes the failures seen in sonic-net/sonic-mgmt#14583 for Arista. |
|
/azpw ms_conflict |
|
/azpw ms_conflict |
wen587
reviewed
Oct 8, 2024
wen587
approved these changes
Oct 8, 2024
ganglyu
approved these changes
Oct 8, 2024
|
Hi @qiluo-msft , can you help merge this one? |
qiluo-msft
approved these changes
Oct 10, 2024
sschlafman
pushed a commit
to sschlafman/sonic-buildimage
that referenced
this pull request
Oct 15, 2024
… chassis (sonic-net#19968) ### Why I did it In the sonic chassis the port table on the host does not lanes. Add conditions in the lab chassis to make lanes not mandatory for chassis devices ### How I did it Add the check in `sonic-port.yang` to make lanes are mandatory in the host config_db only for non-chassis devices. #### How to verify it UT.
qiluo-msft
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Oct 22, 2024
Reverts #3489 since the PR: sonic-net/sonic-buildimage#19968 has merged.
|
@yejianquan please help with cherry-pick |
|
Hi @arlakshm @abdosi , this change need add T1 multiasic as well, would you mind help make one more change to support that? Thanks! @yejianquan we need one more change, once done we could cp the future change and this change. |
@xincunli-sonic do you mean we need to cherry-pick the 2 changes together or is it safe to only cherry-pick this one first? |
yejianquan
added
Approved for 202405 Branch
and removed
Approved for 202405 Branch
labels
liushilongbuaa
added
Approved for 202405 Branch
and removed
Approved for 202405 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 29, 2024
… chassis (sonic-net#19968) ### Why I did it In the sonic chassis the port table on the host does not lanes. Add conditions in the lab chassis to make lanes not mandatory for chassis devices ### How I did it Add the check in `sonic-port.yang` to make lanes are mandatory in the host config_db only for non-chassis devices. #### How to verify it UT.
|
Cherry-pick PR to 202405: #20644 |
mssonicbld
pushed a commit
that referenced
this pull request
Oct 29, 2024
… chassis (#19968) ### Why I did it In the sonic chassis the port table on the host does not lanes. Add conditions in the lab chassis to make lanes not mandatory for chassis devices ### How I did it Add the check in `sonic-port.yang` to make lanes are mandatory in the host config_db only for non-chassis devices. #### How to verify it UT.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Oct 29, 2024
Reverts sonic-net#3489 since the PR: sonic-net/sonic-buildimage#19968 has merged.
mssonicbld
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Oct 30, 2024
Reverts #3489 since the PR: sonic-net/sonic-buildimage#19968 has merged.
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
… chassis (sonic-net#19968) ### Why I did it In the sonic chassis the port table on the host does not lanes. Add conditions in the lab chassis to make lanes not mandatory for chassis devices ### How I did it Add the check in `sonic-port.yang` to make lanes are mandatory in the host config_db only for non-chassis devices. #### How to verify it UT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
In the sonic chassis the port table on the host does not lanes. Add conditions in the lab chassis to make lanes not mandatory for chassis devices
Work item tracking
How I did it
Add the check in
sonic-port.yangto make lanes are mandatory in the host config_db only for non-chassis devices.How to verify it
UT.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)