-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update P4RT docker to Bookworm #18886
Conversation
|
d053c56
to
06782a6
Compare
Is there a way to re-run the
|
rules/config
Outdated
@@ -153,7 +153,7 @@ INCLUDE_DHCP_RELAY = y | |||
INCLUDE_DHCP_SERVER ?= n | |||
|
|||
# INCLUDE_P4RT - build docker-p4rt for P4RT support | |||
INCLUDE_P4RT = n | |||
INCLUDE_P4RT = y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change intentional, to build the P4RT docker by default? Was it brought up/discussed somewhere?
FYI @qiluo-msft for awareness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looked like it had been turned off, since a build failure was encountered at some point. I wasn't able to reproduce the build failure, so I thought it could be turned back on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgsudharsan I see that #16343 disabled the P4RT build by default due to some build issues. Are you still seeing these issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have not enabled it since disabling. I would recommend fixing UT issues I raised before reenabling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments. I went ahead and reverted this particular change, since it's unrelated to upgrading to Bookworm.
Signed-off-by: mkeda <mikeattig@google.com>
06782a6
to
ae56b12
Compare
@saiarcot895 - Are there still concerns on this PR? |
Signed-off-by: mkeda <mikeattig@google.com>
Why I did it
Enable the P4RT docker container to be able to build using Bookworm.
How I did it
Confirm that the P4RT docker is able to build in a local workspace.
How to verify it
See above.
Which release branch to backport (provide reason below if selected)
n/a, this is a feature.
Tested branch (Please provide the tested image version)
Tested with latest branch.
Description for the changelog
Update P4RT docker container to build under Bookworm
Link to config_db schema for YANG module changes
n/a
A picture of a cute animal (not mandatory but encouraged)