Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Seastone] fix issue #18767 psu fan speed issue #18787

Merged
merged 1 commit into from
May 12, 2024

Conversation

qnos
Copy link
Contributor

@qnos qnos commented Apr 24, 2024

Why I did it

Fix issue #18767 fan information could not been shown issue.

How I did it

Add psu fan get_target_speed api support.

How to verify it

Use show platform fan in branch 202311.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Why I did it
Fix issue sonic-net#18787 fan information could not been shown issue.

How I did it
Add psu fan get_target_speed api support.

How to verify it
Use `show platform fan` in branch 202311.
@qnos qnos force-pushed the seastone-issue-18767-fix branch from 5d08361 to a1824ba Compare May 8, 2024 06:19
@lguohan lguohan merged commit 71eb9b9 into sonic-net:master May 12, 2024
17 of 19 checks passed
@mbze430
Copy link

mbze430 commented May 25, 2024

I have a question.

I just downloaded and installed this build:
https://dev.azure.com/mssonic/build/_build/results?buildId=553343&view=results
SONiC.202311.552497-e1bc0f3eb
but the fix is still not there yet.

admin@sonic:~$ show platform fan
Traceback (most recent call last):
  File "/usr/local/bin/fanshow", line 85, in <module>
    fanShow.show()
  File "/usr/local/bin/fanshow", line 75, in show
    table.append((data_dict[DRAWER_FIELD_NAME], data_dict[LED_STATUS_FIELD_NAME], name, speed, data_dict[DIRECTION_FIELD_NAME], presence, status,
KeyError: 'drawer_name'

how can I track from github to dev.azure.com which build will have this particular fix? (sorry for the newb question)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants