[vs]: BMv2-based DPU KVM image #18762

Pterosaur · 2024-04-23T12:26:22Z

Why I did it

Provide POC for development and cooperation.
Test for CI (Azp)

Work item tracking

Microsoft ADO (number only): 27515178

How I did it

HLD: sonic-net/SONiC#1634

How to verify it

Merge PR: sonic-net/sonic-sairedis#1377

Download the vsdpu image from Azp
check the syncd links to the correct DASH SAI

admin@vlab-01:~$ docker exec -ti syncd bash
root@vlab-01:/# dpkg -l | grep sai
ii  libsai                                 1.0.0                          amd64        This package contains DASH libsai
root@vlab-01:/# dpkg -L libsai
/.
/etc
/etc/dash
/etc/dash/dash_pipeline.json
/etc/dash/dash_pipeline_ir.json
/etc/dash/dash_pipeline_p4rt.json
/etc/dash/dash_pipeline_p4rt.txt
/usr
/usr/lib
/usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/libsai.so
root@vlab-01:/# which syncd_dash
/usr/bin/syncd_dash
root@vlab-01:/# ldd /usr/bin/syncd_dash | grep sai
        libsaimetadata.so.0 => /usr/lib/x86_64-linux-gnu/libsaimetadata.so.0 (0x00007f949e99b000)
        libsaimeta.so.0 => /usr/lib/x86_64-linux-gnu/libsaimeta.so.0 (0x00007f949e8ca000)
        libsai.so => /usr/lib/x86_64-linux-gnu/libsai.so (0x00007f949e417000)
root@vlab-01:/# md5sum /usr/lib/x86_64-linux-gnu/libsai.so
9e86fa2f49a824837064d1b8f95b7e48  /usr/lib/x86_64-linux-gnu/libsai.so
root@vlab-01:/# ls /etc/dash
dash_pipeline.json  dash_pipeline_ir.json  dash_pipeline_p4rt.json  dash_pipeline_p4rt.txt

Check the dash engine logs(BMv2) likes following

admin@vlab-01:~$ docker logs dash_engine
Calling target program-options parser
Adding interface eth1 as port 0
[11:20:12.458] [bmv2] [D] [thread 7] Adding interface eth1 as port 0
[11:20:12.500] [bmv2] [E] [thread 7] Add port operation failed
Adding interface eth2 as port 1
[11:20:12.500] [bmv2] [D] [thread 7] Adding interface eth2 as port 1
[11:20:12.556] [bmv2] [E] [thread 7] Add port operation failed
Server listening on 0.0.0.0:9559
[11:22:09.706] [bmv2] [D] [thread 23] Set default default entry for table 'tbl_dash_pipeline241': dash_pipeline241 -
[11:22:09.706] [bmv2] [D] [thread 23] Set default default entry for table 'dash_ingress.vip': dash_ingress.deny -
[11:22:09.706] [bmv2] [D] [thread 23] Set default default entry for table 'tbl_dash_pipeline247': dash_pipeline247 -
[11:22:09.706] [bmv2] [D] [thread 23] Set default default entry for table 'dash_ingress.direction_lookup_stage.direction_lookup': dash_ingress.direction_lookup_stage.set_inbound_direction -
[11:22:09.706] [bmv2] [D] [thread 23] Set default default entry for table 'dash_ingress.appliance': NoAction -
[11:22:09.706] [bmv2] [D] [thread 23] Set default default entry for table 'tbl_eni_lookup33': eni_lookup33 -
[11:22:09.706] [bmv2] [D] [thread 23] Set default default entry for table 'tbl_eni_lookup33_0': eni_lookup33_0 -
[11:22:09.706] [bmv2] [D] [thread 23] Set default default entry for table 'tbl_eni_lookup33_1': eni_lookup33_1 -
[11:22:09.706] [bmv2] [D] [thread 23] Set default default entry for table 
...
[11:23:32.035] [bmv2] [D] [thread 23] Set default default entry for table 'tbl_metering_update92': metering_update92 -
[11:23:32.035] [bmv2] [D] [thread 23] Set default default entry for table 'tbl_metering_update94': metering_update94 -
[11:23:32.035] [bmv2] [D] [thread 23] Set default default entry for table 'tbl_metering_update97': metering_update97 -
[11:23:32.035] [bmv2] [D] [thread 23] Set default default entry for table 'dash_ingress.metering_update_stage.meter_bucket': NoAction -
[11:23:32.035] [bmv2] [D] [thread 23] Set default default entry for table 'tbl_metering_update103': metering_update103 -
[11:23:32.035] [bmv2] [D] [thread 23] Set default default entry for table 'tbl_metering_update105': metering_update105 -
[11:23:32.035] [bmv2] [D] [thread 23] Set default default entry for table 'dash_ingress.metering_update_stage.eni_meter': NoAction -
[11:23:32.035] [bmv2] [D] [thread 23] Set default default entry for table 'tbl_drop_action': dash_ingress.drop_action -
[11:23:32.049] [bmv2] [D] [thread 23] simple_switch target has been notified of a config swap

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

🐯

Signed-off-by: Ze Gan <ganze718@gmail.com>

Pterosaur · 2024-04-25T06:01:58Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2024-04-25T06:02:04Z

Commenter does not have sufficient privileges for PR 18762 in repo sonic-net/sonic-buildimage

Pterosaur · 2024-04-25T06:02:14Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2024-04-25T06:02:16Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2024-04-25T06:02:28Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Ze Gan <ganze718@gmail.com>

lguohan · 2024-05-07T06:49:27Z

sonic-slave-bullseye/Dockerfile.j2

@@ -426,6 +426,37 @@ RUN apt-get update && apt-get install -y eatmydata && eatmydata apt-get install
        default-jdk \
        libgoogle-gson-java

+{%- if CONFIGURED_PLATFORM == "vs" %}


can we just install them by default in the slave container?

No, there are some packages install failure on marvell platform

that's fine, then why not say != marvel?

IMHO, I didn't test all platforms, so == vs is safer than != marvel.
But I fix it by following your suggestion in the latest commit.

lguohan · 2024-05-07T06:52:17Z

Makefile.work

@@ -582,6 +583,7 @@ SONIC_BUILD_INSTRUCTION :=  $(MAKE) \
                           SONIC_ENABLE_BOOTCHART=$(ENABLE_BOOTCHART) \
                           INCLUDE_FIPS=$(INCLUDE_FIPS) \
                           ENABLE_FIPS=$(ENABLE_FIPS) \
+                           ENABLE_DASH_SAI=$(ENABLE_DASH_SAI) \


this introduce this kvm image as build option?

but can we include the docker-dash-engine in kvm vs image by default, then we can enable and disable it at runtime?

Signed-off-by: Ze Gan <ganze718@gmail.com>

Pterosaur · 2024-05-10T03:44:02Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2024-05-10T03:44:05Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2024-05-10T03:44:16Z

Azure Pipelines successfully started running 1 pipeline(s).

Pterosaur · 2024-05-11T15:26:15Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2024-05-11T15:26:17Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2024-05-11T15:26:29Z

Azure Pipelines successfully started running 1 pipeline(s).

lguohan · 2024-05-13T03:04:52Z

sonic-slave-bookworm/Dockerfile.j2

@@ -445,6 +445,34 @@ RUN apt-get update && apt-get install -y \
        hwdata \
        libzip-dev

+{%- if CONFIGURED_PLATFORM == "vs" %}


do we really need this?

Signed-off-by: Ze Gan <ganze718@gmail.com>

Pterosaur · 2024-05-13T15:46:08Z

/azpw run ms_conflict

mssonicbld · 2024-05-13T15:46:11Z

/AzurePipelines run ms_conflict

azure-pipelines · 2024-05-13T15:46:17Z

No pipelines are associated with this pull request.

Pterosaur · 2024-05-14T02:23:30Z

/azpw ms_conflict

lguohan · 2024-05-15T01:17:04Z

sonic-slave-bullseye/Dockerfile.j2

@@ -426,6 +426,37 @@ RUN apt-get update && apt-get install -y eatmydata && eatmydata apt-get install
        default-jdk \
        libgoogle-gson-java

+{%- if CONFIGURED_PLATFORM != "marvell" %}


is it better to use this one?

{%- if CONFIGURED_ARCH == "armhf" and CROSS_BUILD_ENVIRON != "y" %}

I don't understand your suggestion. Will CONFIGURED_ARCH == "armhf" match vs platform?

Done, @lguohan Please check it again

Signed-off-by: Ze Gan <ganze718@gmail.com>

Pterosaur · 2024-05-16T15:34:43Z

/azpw ms_conflict

Pterosaur · 2024-05-17T01:03:52Z

/azpw ms_conflict

Pterosaur · 2024-05-17T03:22:29Z

/azpw ms_conflict

Pterosaur · 2024-05-17T08:20:50Z

/azpw ms_conflict

Pterosaur · 2024-05-17T10:36:59Z

/azpw ms_conflict

Pterosaur changed the title ~~init dash lib~~ [vs]: BMv2-based DPU KVM image Apr 23, 2024

init dash lib

5bb5d2d

Signed-off-by: Ze Gan <ganze718@gmail.com>

Pterosaur force-pushed the bmv2_kvm2 branch from 9a2a799 to 5bb5d2d Compare April 23, 2024 12:28

r12f approved these changes Apr 24, 2024

View reviewed changes

r12f self-requested a review April 24, 2024 00:10

Add jsonpath_ng

f83fea7

Signed-off-by: Ze Gan <ganze718@gmail.com>

Pterosaur force-pushed the bmv2_kvm2 branch 2 times, most recently from 5356946 to 8f60e8b Compare April 28, 2024 15:04

Fix bookworm deps

212172b

Signed-off-by: Ze Gan <ganze718@gmail.com>

Pterosaur force-pushed the bmv2_kvm2 branch from 8f60e8b to 212172b Compare April 28, 2024 15:05

Pterosaur marked this pull request as ready for review April 28, 2024 23:08

Pterosaur requested review from qiluo-msft, xumia and lguohan as code owners April 28, 2024 23:08

Pterosaur mentioned this pull request Apr 28, 2024

[vs]: BMv2-based DPU KVM image #18453

Closed

11 tasks

r12f approved these changes Apr 29, 2024

View reviewed changes

lguohan reviewed May 7, 2024

View reviewed changes

Remove build option ENABLE_DASH_SAI

f511d72

Signed-off-by: Ze Gan <ganze718@gmail.com>

Pterosaur requested a review from lguohan May 12, 2024 01:30

lguohan reviewed May 13, 2024

View reviewed changes

Change vs to non-marvell in slave

8f4fed2

Signed-off-by: Ze Gan <ganze718@gmail.com>

Pterosaur requested a review from lguohan May 14, 2024 02:36

lguohan reviewed May 15, 2024

View reviewed changes

Refactor configured arch in slave

17aba59

Signed-off-by: Ze Gan <ganze718@gmail.com>

Pterosaur requested a review from lguohan May 17, 2024 11:26

lguohan merged commit 3a84ba8 into sonic-net:master May 17, 2024
19 checks passed

wumiaont mentioned this pull request Jun 6, 2024

Latest Master Build Not Successful #19235

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vs]: BMv2-based DPU KVM image #18762

[vs]: BMv2-based DPU KVM image #18762

Pterosaur commented Apr 23, 2024 •

edited

Loading

Pterosaur commented Apr 25, 2024

azure-pipelines bot commented Apr 25, 2024

Pterosaur commented Apr 25, 2024

mssonicbld commented Apr 25, 2024

azure-pipelines bot commented Apr 25, 2024

lguohan May 7, 2024

Pterosaur May 8, 2024

lguohan May 13, 2024

Pterosaur May 13, 2024

lguohan May 7, 2024

This comment was marked as outdated.

Pterosaur commented May 10, 2024

mssonicbld commented May 10, 2024

azure-pipelines bot commented May 10, 2024

Pterosaur commented May 11, 2024

mssonicbld commented May 11, 2024

azure-pipelines bot commented May 11, 2024

lguohan May 13, 2024

Pterosaur commented May 13, 2024

mssonicbld commented May 13, 2024

azure-pipelines bot commented May 13, 2024

Pterosaur commented May 14, 2024

lguohan May 15, 2024

Pterosaur May 15, 2024

Pterosaur May 17, 2024

Pterosaur commented May 16, 2024

Pterosaur commented May 17, 2024

Pterosaur commented May 17, 2024

Pterosaur commented May 17, 2024

Pterosaur commented May 17, 2024

[vs]: BMv2-based DPU KVM image #18762

[vs]: BMv2-based DPU KVM image #18762

Conversation

Pterosaur commented Apr 23, 2024 • edited Loading

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Pterosaur commented Apr 25, 2024

azure-pipelines bot commented Apr 25, 2024

Pterosaur commented Apr 25, 2024

mssonicbld commented Apr 25, 2024

azure-pipelines bot commented Apr 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as outdated.

Pterosaur commented May 10, 2024

mssonicbld commented May 10, 2024

azure-pipelines bot commented May 10, 2024

Pterosaur commented May 11, 2024

mssonicbld commented May 11, 2024

azure-pipelines bot commented May 11, 2024

Choose a reason for hiding this comment

Pterosaur commented May 13, 2024

mssonicbld commented May 13, 2024

azure-pipelines bot commented May 13, 2024

Pterosaur commented May 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pterosaur commented May 16, 2024

Pterosaur commented May 17, 2024

Pterosaur commented May 17, 2024

Pterosaur commented May 17, 2024

Pterosaur commented May 17, 2024

Pterosaur commented Apr 23, 2024 •

edited

Loading