-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Fix 4600c sensors.conf inverted psu number designation #18722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuazhe
force-pushed
the
fix_sensors_conf
branch
from
April 19, 2024 01:54
5854853
to
196bd0e
Compare
yuazhe
changed the title
[Mellanox] standardizing the sensors.conf psu section
[Mellanox] Fix 4600c sensors.conf psu section inverted designation
Apr 19, 2024
yuazhe
changed the title
[Mellanox] Fix 4600c sensors.conf psu section inverted designation
[Mellanox] Fix 4600c sensors.conf inverted psu number designation
Apr 19, 2024
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
I. Fix 4600/4600c psu number inverted issue II. Fix 5600 second psu missing set_power_cap label III. Standardized comments Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
yuazhe
force-pushed
the
fix_sensors_conf
branch
from
April 26, 2024 02:35
196bd0e
to
e60f858
Compare
keboliu
approved these changes
Apr 28, 2024
prgeor
approved these changes
May 20, 2024
/azpw ms_conflict |
liat-grozovik
approved these changes
May 21, 2024
@yuazhe please check if this also needed for 202305 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 23, 2024
…nic-net#18722) - Why I did it This PR is used to standardize several sensors.conf psu section I. Fix 4600/4600c inverted psu number designation II. Fix 5600 second psu miss set_power_cap label III. Standardized comments - How to verify it check sensors command output Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
Cherry-pick PR to 202311: #19054 |
mssonicbld
pushed a commit
that referenced
this pull request
May 23, 2024
…8722) - Why I did it This PR is used to standardize several sensors.conf psu section I. Fix 4600/4600c inverted psu number designation II. Fix 5600 second psu miss set_power_cap label III. Standardized comments - How to verify it check sensors command output Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
May 23, 2024
@yxieca please help to approve this pr for 202305 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This PR is used to standardize several sensors.conf psu section
I. Fix 4600/4600c inverted psu number designation
II. Fix 5600 second psu miss set_power_cap label
III. Standardized comments
Work item tracking
How I did it
How to verify it
check
sensors
command outputWhich release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)