Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Fix 4600c sensors.conf inverted psu number designation #18722

Merged
merged 1 commit into from
May 21, 2024

Conversation

yuazhe
Copy link
Contributor

@yuazhe yuazhe commented Apr 19, 2024

Why I did it

This PR is used to standardize several sensors.conf psu section
I. Fix 4600/4600c inverted psu number designation
II. Fix 5600 second psu miss set_power_cap label
III. Standardized comments

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

check sensors command output

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • 202311

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@yuazhe yuazhe changed the title [Mellanox] standardizing the sensors.conf psu section [Mellanox] Fix 4600c sensors.conf psu section inverted designation Apr 19, 2024
@yuazhe yuazhe changed the title [Mellanox] Fix 4600c sensors.conf psu section inverted designation [Mellanox] Fix 4600c sensors.conf inverted psu number designation Apr 19, 2024
@keboliu keboliu self-requested a review April 19, 2024 02:04
@yuazhe yuazhe marked this pull request as ready for review April 19, 2024 05:58
@yuazhe
Copy link
Contributor Author

yuazhe commented Apr 24, 2024

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

I.   Fix 4600/4600c psu number inverted issue
II.  Fix 5600 second psu missing set_power_cap label
III. Standardized comments

Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
@keboliu keboliu requested a review from prgeor May 10, 2024 07:48
@yuazhe
Copy link
Contributor Author

yuazhe commented May 21, 2024

/azpw ms_conflict

@liat-grozovik
Copy link
Collaborator

@yuazhe please check if this also needed for 202305

@liat-grozovik liat-grozovik merged commit bf556c5 into sonic-net:master May 21, 2024
19 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request May 23, 2024
…nic-net#18722)

- Why I did it
This PR is used to standardize several sensors.conf psu section
I. Fix 4600/4600c inverted psu number designation
II. Fix 5600 second psu miss set_power_cap label
III. Standardized comments

- How to verify it
check sensors command output

Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #19054

mssonicbld pushed a commit that referenced this pull request May 23, 2024
…8722)

- Why I did it
This PR is used to standardize several sensors.conf psu section
I. Fix 4600/4600c inverted psu number designation
II. Fix 5600 second psu miss set_power_cap label
III. Standardized comments

- How to verify it
check sensors command output

Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
@yuazhe
Copy link
Contributor Author

yuazhe commented Jul 11, 2024

@yxieca please help to approve this pr for 202305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants