Add lcov to Bookworm slave container #18544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gcovr package used to have lcov as a runtime dependency. However, that was removed in Debian bug 987818. However, autoconf's code coverage macro file expects lcov and genhtml to be present. It's possible that lcov and genhtml are actually not needed for generating the report, and that gcovr is enough. For now, though, just add lcov (which includes genhtml) into the slave container. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The gcovr package used to have lcov as a runtime dependency. However, that was removed in Debian bug 987818. However, autoconf's code coverage macro file expects lcov and genhtml to be present. This macro is used in sonic-swss-common and likely other submodules.
Work item tracking
How I did it
It's possible that lcov and genhtml are actually not needed for generating the report, and that gcovr is enough. For now, though, just add lcov (which includes genhtml) into the slave container.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)