Treat bcmcmd as a supervisor task so we could collect stdout/stderr #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
lguohan
reviewed
Jun 28, 2018
| @@ -33,5 +34,5 @@ wait_syncd() { | |||
| # If this platform has an initialization file for the Broadcom LED microprocessor, load it | |||
| if [ -r ${PLATFORM_DIR}/led_proc_init.soc ]; then | |||
| wait_syncd | |||
| /usr/bin/bcmcmd -t 60 "rcload ${PLATFORM_DIR}/led_proc_init.soc" | |||
| supervisorctl start bcmcmd | |||
There was a problem hiding this comment.
change the task name to ledinit #Resolved
There was a problem hiding this comment.
+1. This way we can differentiate other tasks run with bcmcmd, if we ever add any. #Resolved
jleveque
reviewed
Jun 28, 2018
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env bash | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Reason for changing? Using #!/usr/bin/env bash will work even if the bash installation directory ever changes (e.g., /sbin/bash). #Resolved
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
lguohan
approved these changes
Jun 28, 2018
jleveque
approved these changes
Jun 28, 2018
lguohan
pushed a commit
that referenced
this pull request
Oct 17, 2018
5 tasks
ayurkiv-nvda
added a commit
to ayurkiv-nvda/sonic-buildimage
that referenced
this pull request
Aug 11, 2021
Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> d8ca31c (origin/master, origin/HEAD, master) [vnet/vxlan] Add support of multiple mappers for the VxLAN tunnel (sonic-net#1843) 7280e19 [orchagent][ports] Add port reference increment / decrement to lag member add / remove flows (sonic-net#1825) 0217b66 [nhg]: Add support for weight in nexthop group member. (sonic-net#1853) df96059 VOQ: Nexthop for remote VOQ LC should be created on inband OIF. (sonic-net#1823) 8f7ea14 Code changes to support IPv6 Link local enhancements (sonic-net#1463) 8674b3c Open record file in append mode (sonic-net#1845)
prsunny
pushed a commit
that referenced
this pull request
Aug 12, 2021
d8ca31c (origin/master, origin/HEAD, master) [vnet/vxlan] Add support of multiple mappers for the VxLAN tunnel (#1843) 7280e19 [orchagent][ports] Add port reference increment / decrement to lag member add / remove flows (#1825) 0217b66 [nhg]: Add support for weight in nexthop group member. (#1853) df96059 VOQ: Nexthop for remote VOQ LC should be created on inband OIF. (#1823) 8f7ea14 Code changes to support IPv6 Link local enhancements (#1463) 8674b3c Open record file in append mode (#1845) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
vdahiya12
added a commit
to vdahiya12/sonic-buildimage
that referenced
this pull request
Oct 20, 2021
8768089 (HEAD -> 202012, origin/202012) Remove exec from platform_reboot_plugin call to handle any hang issue. (sonic-net#1879) ae5d90c Validate input of ```config mirror_session add``` (sonic-net#1825) 44d3a3b [show][config] fix the muxcable commands for interface naming mode (sonic-net#1862) 0a4933e [TH3] Skipp Control Plane Assist on WARM Reboot for TH3 HWSKUs (sonic-net#1861) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Oct 24, 2021
8768089 (HEAD -> 202012, origin/202012) Remove exec from platform_reboot_plugin call to handle any hang issue. (#1879) ae5d90c Validate input of ```config mirror_session add``` (#1825) 44d3a3b [show][config] fix the muxcable commands for interface naming mode (#1862) 0a4933e [TH3] Skipp Control Plane Assist on WARM Reboot for TH3 HWSKUs (#1861) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
5 tasks
wen587
added a commit
that referenced
this pull request
Oct 26, 2021
8ea834b [sonic_installer] Change sonic_installer check ASIC mismatch by platforms list (#1836) 9017d99 Fix the option missing in kernel config issue (#1888) 6595ad4 [mlag] fix log print sequence (#1730) e600e1c CLI command to load config in Yang format (#1781) 00948d0 Fix the target db version of portchannel-key test (#1842) 6412fea [sonic-package-manager] remove make_python_identifier (#1801) f738818 [sonic-package-manager] stop service explicitelly before uninstalling package (#1805) d8ee5e9 Remove exec from platform_reboot_plugin call to handle any hang issue. (#1879) 827fcee [chassis][routecheck]filter out the chassis internal interfaces (#1798) 4d732c6 [generic_config_updater] Logging (#1864) 25bb184 [config]: Add loopback interfaces to interface name checker (#1869) c950a55 Validate input of config mirror_session add (#1825) 9ab20fd [show][config] fix the muxcable commands for interface naming mode (#1862) 476b3a4 [multi-asic][cli][chassis-db] Avoid connecting to chassis db for cli commands executed from linecard (#1707)
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
…mber add / remove flows (sonic-net#1825) * Added code to increment the port reference counter on the creation of a lag membership that involves that port. Also added code to decrement the counter on the removal of that lag membership as well. This prevents the port from being removed before the lag membership is.
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
* Validate input of add mirror session Signed-off-by: bingwang <bingwang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clean the unix socket file before dsserve