[Yang-models] Update sonic-vlan.yang to better constrain Vlan name #18207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~ Signed-off-by: matiAlfaro <mati@marvell.com>
matiAlfaro
changed the title
|
Thanks for the effort to improve sonic-vlan.yang! |
isabelmsft
reviewed
Feb 29, 2024
| @@ -178,7 +182,7 @@ module sonic-vlan { | |||
|
|
|||
| leaf name { | |||
| type string { | |||
| pattern 'Vlan([0-9]{1,3}|[1-3][0-9]{3}|[4][0][0-8][0-9]|[4][0][9][0-4])'; | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
The original regex allows for Vlan0, Vlan00, Vlan000, Vlan01 ext...
I'll have a go at #12256
There was a problem hiding this comment.
you're right, the first group in original regex was too broad. And thanks!
ganglyu
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~
Related to #3155
Update sonic-vlan.yang model to match requirement as described in #16975
Why I did it
Work item tracking
How I did it
Update Vlan name regex
Update runVlanSpecialTest to skip Vlan0 (as it is illegal)
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
master
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)