Make macsec container to build with bookworm #18148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can some of you help to review sonic-net/sonic-wpa-supplicant#80. The failures are because of that. |
Will wait till this PR is merged |
k-v1
reviewed
Feb 21, 2024
|
@saiarcot895 @k-v1 help to review it again? Thx |
|
@saiarcot895 @k-v1 Semgrep did not run. Anyway you can help to trigger this check? |
k-v1
reviewed
Feb 27, 2024
k-v1
approved these changes
Feb 27, 2024
|
@saiarcot895 @k-v1 @xumia Help to review and approve the PR? Thanks. |
k-v1
approved these changes
Feb 28, 2024
|
@qiluo-msft help to review the PR? Seems needs reviewers with write access to approve. |
sonic-otn
pushed a commit
to Weitang-Zheng/sonic-buildimage
that referenced
this pull request
Mar 11, 2024
Why I did it We Nokia took the task to make macsec container to work with bookworm. This PR requires another PR for sonic-wpa-supplicant(sonic-net/sonic-wpa-supplicant#80) to be in first. Otherwise sonic build will fail for bookworm wpasupplicant debian package. How I did it How to verify it After build and boot up system with new image, macsec container should run with bookworm. Corresponding mgmt macsec suite will work here. Which release branch to backport (provide reason below if selected) Tested branch (Please provide the tested image version) Tested with latest master of sonic-buildimage. Built vs image and loaded into vs testing environment. Code pass with macsec test suites. Description for the changelog Make macsec container to build with bookworm
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Mar 12, 2024
Why I did it We Nokia took the task to make macsec container to work with bookworm. This PR requires another PR for sonic-wpa-supplicant(sonic-net/sonic-wpa-supplicant#80) to be in first. Otherwise sonic build will fail for bookworm wpasupplicant debian package. How I did it How to verify it After build and boot up system with new image, macsec container should run with bookworm. Corresponding mgmt macsec suite will work here. Which release branch to backport (provide reason below if selected) Tested branch (Please provide the tested image version) Tested with latest master of sonic-buildimage. Built vs image and loaded into vs testing environment. Code pass with macsec test suites. Description for the changelog Make macsec container to build with bookworm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
We Nokia took the task to make macsec container to work with bookworm.
This PR requires another PR for sonic-wpa-supplicant(sonic-net/sonic-wpa-supplicant#80) to be in first. Otherwise sonic build will fail for bookworm wpasupplicant debian package.
How I did it
How to verify it
After build and boot up system with new image, macsec container should run with bookworm. Corresponding mgmt macsec suite will work here.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Tested with latest master of sonic-buildimage. Built vs image and loaded into vs testing environment. Code pass with macsec test suites.
Description for the changelog
Make macsec container to build with bookworm