Ipmitool bookworm: Fix and patch enterprise-numbers URL #17878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajib-dutta1
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
rules/ipmitool.mk
Outdated
|
|
||
| IPMITOOL_DBG = ipmitool-dbgsym_$(IPMITOOL_VERSION_FULL)_$(CONFIGURED_ARCH).deb | ||
| $(eval $(call add_derived_package,$(IPMITOOL),$(IPMITOOL_DBG))) | ||
|
|
There was a problem hiding this comment.
can you please remove the empty lines?.
slave.mk
Outdated
| @@ -441,7 +441,6 @@ $(info "ENABLE_BOOTCHART : "$(ENABLE_BOOTCHART)") | |||
| $(info "INCLUDE_FIPS" : "$(INCLUDE_FIPS)") | |||
| $(info "ENABLE_TRANSLIB_WRITE" : "$(ENABLE_TRANSLIB_WRITE)") | |||
| $(info "ENABLE_NATIVE_WRITE" : "$(ENABLE_NATIVE_WRITE)") | |||
| $(info "ENABLE_DIALOUT" : "$(ENABLE_DIALOUT)") | |||
There was a problem hiding this comment.
Why ENABLE_DIALOUT is removed?.
|
@aravindmani-1 can you please re-review? |
saiarcot895
reviewed
Jan 29, 2024
| @@ -101,6 +101,10 @@ sudo mkdir -p $FILESYSTEM_ROOT_USR_LIB_SYSTEMD_SYSTEM | |||
| sudo dpkg --root=$FILESYSTEM_ROOT -i $debs_path/ifupdown2_*.deb || \ | |||
| sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y install -f | |||
|
|
|||
| # Install a patched version of ipmitool (and its dependencies via 'apt-get -y install -f') | |||
| sudo dpkg --root=$FILESYSTEM_ROOT -i $debs_path/ipmitool_*.deb || \ | |||
| sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y install -f | |||
There was a problem hiding this comment.
In build_debian.sh, can you remove the ipmitool package installation from there, to make sure this version is the only version that gets installed?
There was a problem hiding this comment.
I pushed the changed asked above.
root@sonic:/home/admin# show ver
SONiC Software Version: SONiC.master.0-dirty-20240209.233855
SONiC OS Version: 12
Distribution: Debian 12.4
Kernel: 6.1.0-11-2-amd64
Build commit: bd47fd1
Build date: Sat Feb 10 01:35:50 UTC 2024
Built by: commbuild@rajvm
Platform: x86_64-dellemc_s5212f_c3538-r0
HwSKU: DellEMC-S5212f-P-25G
ASIC: broadcom
ASIC Count: 1
Serial Number: CQY67C3
Model Number: 0VK93C
Hardware Revision: 01
Uptime: 07:59:58 up 4 min, 1 user, load average: 5.00, 4.12, 1.78
Date: Tue 13 Feb 2024 07:59:58
root@sonic:/home/admin# ipmitool raw 0x04 0x2d 0x31
Get Device ID command failed: 0xb1 Unknown (0xB1)
Received a response with unexpected ID 0 vs. 1
00 c0 01 80
root@sonic:/home/admin# ipmitool raw 0x04 0x2d 0x31
00 c0 01 80
root@sonic:/home/admin# dpkg -l ipmitool
||/ Name Version Architecture Description
+++-==============-============-============-==================================>
ii ipmitool 1.8.19-4 amd64 utility for IPMI control with kern>
…net#17858) * [dhcp_server] Remove dependency in port-name-alias-map.txt.j2
…mage into ipmitool_bookworm
|
Can you update the title to show what is being fixed? |
rajib-dutta1
changed the title
Done. |
rajib-dutta1
changed the title
saiarcot895
approved these changes
Feb 14, 2024
aravindmani-1
approved these changes
Feb 14, 2024
|
@saiarcot895 #18094 is merged and it looks like the pipelines have passed. Can this be merged? |
|
@qiluo-msft @lguohan @xumia please review/approve/merge, thanks. This is needed as part of the bookworm upgrade. |
qiluo-msft
approved these changes
Feb 21, 2024
vivekrnv
pushed a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Mar 8, 2024
) ### Why I did it ipmitool utility is used to access various HW sensors. Some platforms use "ipmitool raw " to read specific addresses. ipmitool_1.8.19-4_amd64.deb, that is part of bookworm has a defect. The package is missing file enterprise.txt that is expected by the "raw read" code path. It is so because the file the .deb tries to download at the build time does not have the necessary extension as it is available on remote server: https://www.iana.org/assignments/enterprise-numbers.txt ### How I did it The defect had been fixed using coding changes in next unstable version of Linux. It is expected to be available in future stable version of the OS. Hence to keep the changes to minimal, the .dsc file is downloaded and only the Makefile is modified to download the correct file. To make is work as patch necessary changes are made. #### How to verify it Build log is attached and installation of the file is noted line sonic-net#2274 When using vanilla bookworm on platforms like 5212 or 5224: ------------------------------------------------------------------- root@sonic:~# ipmitool raw 0x04 0x2d 0x31 IANA PEN registry open failed: No such file or directory 00 c0 01 80 When fixed we should not see the above error: -------------------------------------------------- root@sonic:/home/admin# ipmitool raw 0x04 0x2d 0x31 00 c0 00 80 ### Description for the changelog This change is to address ipmitool raw read issue. This patch must be removed once it is available in next stable Linux release that contains the fix. ipmitool/ipmitool@1edb0e2
sonic-otn
pushed a commit
to Weitang-Zheng/sonic-buildimage
that referenced
this pull request
Mar 11, 2024
) ### Why I did it ipmitool utility is used to access various HW sensors. Some platforms use "ipmitool raw " to read specific addresses. ipmitool_1.8.19-4_amd64.deb, that is part of bookworm has a defect. The package is missing file enterprise.txt that is expected by the "raw read" code path. It is so because the file the .deb tries to download at the build time does not have the necessary extension as it is available on remote server: https://www.iana.org/assignments/enterprise-numbers.txt ### How I did it The defect had been fixed using coding changes in next unstable version of Linux. It is expected to be available in future stable version of the OS. Hence to keep the changes to minimal, the .dsc file is downloaded and only the Makefile is modified to download the correct file. To make is work as patch necessary changes are made. #### How to verify it Build log is attached and installation of the file is noted line sonic-net#2274 When using vanilla bookworm on platforms like 5212 or 5224: ------------------------------------------------------------------- root@sonic:~# ipmitool raw 0x04 0x2d 0x31 IANA PEN registry open failed: No such file or directory 00 c0 01 80 When fixed we should not see the above error: -------------------------------------------------- root@sonic:/home/admin# ipmitool raw 0x04 0x2d 0x31 00 c0 00 80 ### Description for the changelog This change is to address ipmitool raw read issue. This patch must be removed once it is available in next stable Linux release that contains the fix. ipmitool/ipmitool@1edb0e2
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Mar 12, 2024
) ### Why I did it ipmitool utility is used to access various HW sensors. Some platforms use "ipmitool raw " to read specific addresses. ipmitool_1.8.19-4_amd64.deb, that is part of bookworm has a defect. The package is missing file enterprise.txt that is expected by the "raw read" code path. It is so because the file the .deb tries to download at the build time does not have the necessary extension as it is available on remote server: https://www.iana.org/assignments/enterprise-numbers.txt ### How I did it The defect had been fixed using coding changes in next unstable version of Linux. It is expected to be available in future stable version of the OS. Hence to keep the changes to minimal, the .dsc file is downloaded and only the Makefile is modified to download the correct file. To make is work as patch necessary changes are made. #### How to verify it Build log is attached and installation of the file is noted line sonic-net#2274 When using vanilla bookworm on platforms like 5212 or 5224: ------------------------------------------------------------------- root@sonic:~# ipmitool raw 0x04 0x2d 0x31 IANA PEN registry open failed: No such file or directory 00 c0 01 80 When fixed we should not see the above error: -------------------------------------------------- root@sonic:/home/admin# ipmitool raw 0x04 0x2d 0x31 00 c0 00 80 ### Description for the changelog This change is to address ipmitool raw read issue. This patch must be removed once it is available in next stable Linux release that contains the fix. ipmitool/ipmitool@1edb0e2
9 tasks
saiarcot895
added a commit
to saiarcot895/sonic-buildimage
that referenced
this pull request
Sep 25, 2024
…c-net#17878)" The latest version of ipmitool in Debian has the enterprise-numbers.txt file. Don't compile this package locally anymore. This reverts commit 4753953.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipmitool_1.8.19-4_amd64.deb.log
Why I did it
ipmitool utility is used to access various HW sensors. Some platforms use "ipmitool raw " to read specific addresses.
ipmitool_1.8.19-4_amd64.deb, that is part of bookworm has a defect. The package is missing file enterprise.txt that is expected by the "raw read" code path.
It is so because the file the .deb tries to download at the build time does not have the necessary extension as it is available on remote server: https://www.iana.org/assignments/enterprise-numbers.txt
Work item tracking
NA
How I did it
The defect had been fixed using coding changes in next unstable version of Linux. It is expected to be available in future stable version of the OS. Hence to keep the changes to minimal, the .dsc file is downloaded and only the Makefile is modified to download the correct file. To make is work as patch necessary changes are made.
How to verify it
Build log is attached and installation of the file is noted line #2274
When using vanilla bookworm on platforms like 5212 or 5224:
root@sonic:~# ipmitool raw 0x04 0x2d 0x31
IANA PEN registry open failed: No such file or directory
00 c0 01 80
When fixed we should not see the above error:
root@sonic:/home/admin# ipmitool raw 0x04 0x2d 0x31
00 c0 00 80
Which release branch to backport (provide reason below if selected)
None
Tested branch (Please provide the tested image version)
bookworm
Description for the changelog
This change is to address ipmitool raw read issue. This patch must be removed once it is available in next stable Linux release that contains the fix.
ipmitool/ipmitool@1edb0e2
PR#17878
Link to config_db schema for YANG module changes
NA
A picture of a cute animal (not mandatory but encouraged)