[dhcp_server] add config dhcp server range #17741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaqiangz
reviewed
Jan 11, 2024
| ctx = click.get_current_context() | ||
| dbconn = db.db | ||
| key = "DHCP_SERVER_IPV4_RANGE|" + range_name | ||
| if dbconn.exists("CONFIG_DB", key): |
There was a problem hiding this comment.
How about add checks to make sure range is not used in DHCP_SERVER_IPV4 table and add a not required argument '--force' to bypass the check?
yaqiangz
approved these changes
Jan 11, 2024
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add config dhcp server range add / update / delete
Work item tracking
How I did it
Add command to config plugin
How to verify it
Run unittest and run manually on latest image
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Latest public image
Description for the changelog
Add config dhcp_server range related functions
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)