Update smartmontool version >= v7.4 #17635

prgeor · 2023-12-28T18:37:45Z

Why I did it

Update smartmontool verson to 7.4. This is done to prevent smartmontools service to exit with non-zero exit status on platform that does not have a SSD/disk to be monitored.

Until Debian Bullseye (which had smartmontools 7.2), Debian had a patch applied that changed the default quit mode to never exit. A bug report was filed on Debian, saying that the source code patch isn't needed and could just be done via command line options, and also that smartmontools 7.3 has a new built-in option to exit with 0 if there are no monitorable devices found (which prevents systemd from treating it as a service failure). Because of that, Debian Bookworm (which also upgraded to 7.3) removed the patch and restored the default behavior of exiting with exit code 17 if there are no devices found.

Smartmontools v7.3 has this issue, because of which smartd exits with non-zero exit status even with "-q" option.

Work item tracking

Microsoft ADO (number only):

How I did it

Update the smartmontools to version 7.4 which has the fix for exiting gracefully if no monitoring device is found
Added smartd option "-q nodev0" to allow smartd to exit with status 0 if no monitoring device found

How to verify it

smartd running version is now v7.4 (stable on bookworm is v7.3)

Smartd is now exiting successfully (exit status=0) if no SSD device found

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

k-v1 · 2024-01-01T14:10:58Z

files/build_templates/sonic_debian_extension.j2

+echo "deb http://deb.debian.org/debian bookworm-backports main" | sudo tee -a $FILESYSTEM_ROOT/etc/apt/sources.list > /dev/null
+sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get update


sources.list is generated based on this template:

sonic-buildimage/files/apt/sources.list.j2

Line 15 in c410b18

deb [arch={{ ARCHITECTURE }}] {{ mirror_url }} {{ DISTRIBUTION }}-backports main contrib {{ nonfree_component }}

So you just need to install this package and copy config file without any additional actions.

@k-v1 your suggestion is not working

Here is the latest build failure :- https://dev.azure.com/mssonic/be1b070f-be15-4154-aade-b1d3bfb17054/_apis/build/builds/457492/logs/58

By default all SONiC builds on github use these options:
SONIC_VERSION_CONTROL_COMPONENTS=deb,py2,py3,web,git,docker
and
MIRROR_SNAPSHOT=y

It means we use not default debian mirror like deb.debian.org but snapshot from here https://github.com/sonic-net/sonic-buildimage/blob/master/files/build/versions/default/versions-mirror
You build failed because your version of smartmontools (smartmontools=7.4-2~bpo12+1) is not available for current snapshot (http://packages.trafficmanager.net/snapshot/debian/20231027T000138Z bookworm-backports).

So my suggestion is correct and you may also remove apt-get update from your patch.
But you probably need ask help from someone (maybe @xumia) to update version of debian snapshot in files/build/versions.

Also I'm not sure it's correct to lock version if you install this package from debian mirror.
If you need a specific version of smartmontools like 7.4-2 you should build the package from source.
If you need to install this package from debian bookworm-backports you should use command apt-get -y install -t bookworm-backports smartmontools (without version).

Looks like the version upgrade pipeline has been failing on master branch at least since October, because Barefoot is failing to build.

@xumia @lguohan can we disable the Barefoot build for 202311 and master, considering that platform has been failing to build for months? Looks like the SAI library for that platform needs to be updated.

lguohan · 2024-01-04T18:50:18Z

files/build_templates/sonic_debian_extension.j2

-sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y install smartmontools
+echo "deb http://deb.debian.org/debian bookworm-backports main" | sudo tee -a $FILESYSTEM_ROOT/etc/apt/sources.list > /dev/null
+sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get update
+sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y install -t bookworm-backports smartmontools=7.4-2~bpo12+1


last time we updated smartmontools, it brought many dependencies which was hard to manage later.

in this case, what else dependency package it got installed? can you share the log?

@lguohan this is for 202311 for comparison, let me share for master (bookworm)

@lguohan on master(bookworm) running

can you get the version to see what else we are bringing from backport repo?

root@str3-7060-acs-1:~# apt-cache show smartmontools | grep Depends Depends: debianutils (>= 2.2), lsb-base (>= 3.2-14), libc6 (>= 2.27), libcap-ng0 (>= 0.7.9), libgcc-s1 (>= 3.0), libselinux1 (>= 3.1~), libstdc++6 (>= 5.2), libsystemd0

@lguohan below is the dependent versions in 202305

admin@str3-7060-acs-2:~$ apt-cache show smartmontools | grep Depends
Depends: debianutils (>= 2.2), lsb-base (>= 3.2-14), libc6 (>= 2.27), libcap-ng0 (>= 0.7.9), libgcc-s1 (>= 3.0), libselinux1 (>= 3.1~), libstdc++6 (>= 5.2), libsystemd0 admin@str3-7060-acs-2:~$

Why I did it Update smartmontool verson to 7.4. This is done to prevent smartmontools service to exit with non-zero exit status on platform that does not have a SSD/disk to be monitored. Until Debian Bullseye (which had smartmontools 7.2), Debian had a patch applied that changed the default quit mode to never exit. A bug report was filed on Debian, saying that the source code patch isn't needed and could just be done via command line options, and also that smartmontools 7.3 has a new built-in option to exit with 0 if there are no monitorable devices found (which prevents systemd from treating it as a service failure). Because of that, Debian Bookworm (which also upgraded to 7.3) removed the patch and restored the default behavior of exiting with exit code 17 if there are no devices found. Smartmontools v7.3 has this issue, because of which smartd exits with non-zero exit status even with "-q" option. How I did it Update the smartmontools to version 7.4 which has the fix for exiting gracefully if no monitoring device is found Added smartd option "-q nodev0" to allow smartd to exit with status 0 if no monitoring device found

prgeor force-pushed the smartd branch from ce95924 to 26fffb1 Compare December 29, 2023 23:43

Update smartmontool version to v7.4

18614bf

prgeor force-pushed the smartd branch from 351f6f6 to 18614bf Compare December 31, 2023 06:21

prgeor requested a review from saiarcot895 December 31, 2023 09:19

prgeor marked this pull request as ready for review December 31, 2023 09:21

prgeor requested a review from lguohan as a code owner December 31, 2023 09:21

k-v1 reviewed Jan 1, 2024

View reviewed changes

lguohan reviewed Jan 4, 2024

View reviewed changes

Address review comments

0ac947b

prgeor force-pushed the smartd branch from 3ee6de9 to 0ac947b Compare January 25, 2024 18:39

saiarcot895 approved these changes Jan 25, 2024

View reviewed changes

k-v1 approved these changes Jan 25, 2024

View reviewed changes

prgeor changed the title ~~Update smartmontool version to v7.4~~ Update smartmontool version >= v7.4 Feb 4, 2024

lguohan enabled auto-merge (squash) February 12, 2024 17:36

lguohan disabled auto-merge February 12, 2024 17:36

lguohan merged commit 0564ce4 into sonic-net:master Feb 12, 2024
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update smartmontool version >= v7.4 #17635

Update smartmontool version >= v7.4 #17635

prgeor commented Dec 28, 2023 •

edited

Loading

k-v1 Jan 1, 2024

prgeor Jan 18, 2024

k-v1 Jan 18, 2024

k-v1 Jan 18, 2024

saiarcot895 Jan 18, 2024

lguohan Jan 4, 2024

prgeor Jan 18, 2024

prgeor Feb 4, 2024

lguohan Feb 5, 2024

prgeor Feb 9, 2024

prgeor Feb 12, 2024 •

edited

Loading

		echo "deb http://deb.debian.org/debian bookworm-backports main" \| sudo tee -a $FILESYSTEM_ROOT/etc/apt/sources.list > /dev/null
		sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get update

Update smartmontool version >= v7.4 #17635

Update smartmontool version >= v7.4 #17635

Conversation

prgeor commented Dec 28, 2023 • edited Loading

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prgeor Feb 12, 2024 • edited Loading

Choose a reason for hiding this comment

prgeor commented Dec 28, 2023 •

edited

Loading

prgeor Feb 12, 2024 •

edited

Loading