-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Deprecate the mirror packages.trafficmanager.net/debian #17113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azpw ms_conflict |
liushilongbuaa
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
StormLiangMS
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Nov 9, 2023
…c-net#17113) Why I did it Fix the issue: sonic-net#17107 Work item tracking Microsoft ADO (number only): 25746782 How I did it Deprecate the no use and out of service mirrors. http://packages.trafficmanager.net/debian/debian http://packages.trafficmanager.net/debian/debian-security/ Enable the snapshot mirror by default if reproducible flag set. How to verify it
Cherry-pick PR to 202305: #17128 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Nov 9, 2023
…c-net#17113) Why I did it Fix the issue: sonic-net#17107 Work item tracking Microsoft ADO (number only): 25746782 How I did it Deprecate the no use and out of service mirrors. http://packages.trafficmanager.net/debian/debian http://packages.trafficmanager.net/debian/debian-security/ Enable the snapshot mirror by default if reproducible flag set. How to verify it
11 tasks
Cherry-pick PR to 202211: #17129 |
11 tasks
mssonicbld
added a commit
that referenced
this pull request
Nov 9, 2023
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
Nov 9, 2023
11 tasks
1 similar comment
2 similar comments
mssonicbld
added a commit
that referenced
this pull request
Nov 15, 2023
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
Nov 15, 2023
lguohan
pushed a commit
that referenced
this pull request
May 19, 2024
…eb (#17148) Fix #17113 If we set MIRROR_SNAPSHOT=y in build_mirror_config.sh then we have incorrect value of MIRROR_SNAPSHOT in other places like buildinfo/config/buildinfo.config How I did it Override MIRROR_SNAPSHOT=y in rules/config if SONIC_VERSION_CONTROL_COMPONENTS=all or SONIC_VERSION_CONTROL_COMPONENTS includes deb component. How to verify it Start to build with different values of SONIC_VERSION_CONTROL_COMPONENTS and MIRROR_SNAPSHOT in cmdline and check value of MIRROR_SNAPSHOT in buildinfo.config and debian mirrors in sources.list files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix the issue: #17107
Work item tracking
How I did it
http://packages.trafficmanager.net/debian/debian
http://packages.trafficmanager.net/debian/debian-security/
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)