Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Deprecate the mirror packages.trafficmanager.net/debian #17113

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

xumia
Copy link
Collaborator

@xumia xumia commented Nov 7, 2023

Why I did it

Fix the issue: #17107

Work item tracking
  • Microsoft ADO (number only): 25746782

How I did it

  1. Deprecate the no use and out of service mirrors.
    http://packages.trafficmanager.net/debian/debian
    http://packages.trafficmanager.net/debian/debian-security/
  2. Enable the snapshot mirror by default if reproducible flag set.

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liushilongbuaa
Copy link
Contributor

/azpw ms_conflict

Copy link
Contributor

@liushilongbuaa liushilongbuaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 7b6f7a6 into sonic-net:master Nov 9, 2023
23 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Nov 9, 2023
…c-net#17113)

Why I did it
Fix the issue: sonic-net#17107

Work item tracking
Microsoft ADO (number only): 25746782
How I did it
Deprecate the no use and out of service mirrors.
http://packages.trafficmanager.net/debian/debian
http://packages.trafficmanager.net/debian/debian-security/
Enable the snapshot mirror by default if reproducible flag set.
How to verify it
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #17128

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Nov 9, 2023
…c-net#17113)

Why I did it
Fix the issue: sonic-net#17107

Work item tracking
Microsoft ADO (number only): 25746782
How I did it
Deprecate the no use and out of service mirrors.
http://packages.trafficmanager.net/debian/debian
http://packages.trafficmanager.net/debian/debian-security/
Enable the snapshot mirror by default if reproducible flag set.
How to verify it
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #17129

@mssonicbld
Copy link
Collaborator

@xumia cherry pick PR didn't pass PR checker. Please check!!!
#17129

1 similar comment
@mssonicbld
Copy link
Collaborator

@xumia cherry pick PR didn't pass PR checker. Please check!!!
#17129

@mssonicbld
Copy link
Collaborator

@xumia cherry pick PR didn't pass PR checker. Please check!!!
#17129

2 similar comments
@mssonicbld
Copy link
Collaborator

@xumia cherry pick PR didn't pass PR checker. Please check!!!
#17129

@mssonicbld
Copy link
Collaborator

@xumia cherry pick PR didn't pass PR checker. Please check!!!
#17129

lguohan pushed a commit that referenced this pull request May 19, 2024
…eb (#17148)

Fix #17113
If we set MIRROR_SNAPSHOT=y in build_mirror_config.sh
then we have incorrect value of MIRROR_SNAPSHOT in other places like buildinfo/config/buildinfo.config

How I did it
Override MIRROR_SNAPSHOT=y in rules/config if
SONIC_VERSION_CONTROL_COMPONENTS=all or
SONIC_VERSION_CONTROL_COMPONENTS includes deb component.

How to verify it
Start to build with different values of SONIC_VERSION_CONTROL_COMPONENTS and MIRROR_SNAPSHOT in cmdline
and check value of MIRROR_SNAPSHOT in buildinfo.config and debian mirrors in sources.list files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants