[Banner] Add new feature including config, yang and tests #16957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SviatoslavBoichuk
requested review from
qiluo-msft and
lguohan
as code owners
This was referenced Nov 20, 2023
sanal-siva
reviewed
Nov 29, 2023
| echo -e "$LOGIN" > /etc/issue | ||
| echo -e "$MOTD" > /etc/motd | ||
| echo -e "$LOGOUT" > /etc/logout_message | ||
| fi |
There was a problem hiding this comment.
If state is disabled, are you planning clear banner files?
There was a problem hiding this comment.
No, we do not clean banner messages.
liat-grozovik
changed the title
|
/azpw run sonic-net.sonic-buildimage |
|
/AzurePipelines run sonic-net.sonic-buildimage |
|
No pipelines are associated with this pull request. |
SviatoslavBoichuk
force-pushed
the
dev-banner-feature
branch
from
bbbd9c1 to
b0abf75
Compare
|
Please resolve the conflict. #Closed |
qiluo-msft
reviewed
Jan 14, 2024
| @@ -0,0 +1,50 @@ | |||
| module sonic-banner { | |||
| yang-version 1.1; | |||
qiluo-msft
reviewed
Jan 14, 2024
| @@ -0,0 +1,17 @@ | |||
| [Unit] | |||
| Description=Update banner config based on configdb | |||
There was a problem hiding this comment.
I have a later comment on HLD https://github.com/sonic-net/SONiC/pull/1361/files#r1451662677 #Closed
ganglyu
reviewed
Jan 15, 2024
| description "BANNER_MESSAGE part of config_db.json"; | ||
| container MESSAGE { | ||
| leaf state { | ||
| type string { |
There was a problem hiding this comment.
https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-templates/sonic-types.yang.j2#L127
Can you use admin_mode from sonic-types.yang?
wen587
reviewed
Jan 15, 2024
| } | ||
| } /* end of container MESSAGE */ | ||
| } | ||
| /* end of container BANNER_MESSAGE */ |
There was a problem hiding this comment.
please keep the same ending style like line 45
SviatoslavBoichuk
force-pushed
the
dev-banner-feature
branch
2 times, most recently
from
77747b9 to
3d8a7ed
Compare
Fixed conflicts |
SviatoslavBoichuk
force-pushed
the
dev-banner-feature
branch
from
3d8a7ed to
7cee98d
Compare
SviatoslavBoichuk
force-pushed
the
dev-banner-feature
branch
from
7cee98d to
0ff79e8
Compare
SviatoslavBoichuk
force-pushed
the
dev-banner-feature
branch
from
0ff79e8 to
27550c6
Compare
|
Reviewers, can you please help to check the updates to see if you are ok to approve this PR? Thanks. |
ganglyu
approved these changes
Mar 18, 2024
wen587
approved these changes
Mar 18, 2024
qiluo-msft
approved these changes
Mar 24, 2024
This was referenced Apr 18, 2024
Closed
6 tasks
ganglyu
added a commit
to sonic-net/sonic-gnmi
that referenced
this pull request
Apr 18, 2024
Why I did it sonic-net/sonic-buildimage#16957 Above PR introduced "\n" in config_db, and current GNMI implementation does not support such config. How I did it Update yang validation part to read config from file. How to verify it Run GNMI end to end test.
ganglyu
added a commit
to ganglyu/sonic-gnmi
that referenced
this pull request
Jun 18, 2024
Why I did it sonic-net/sonic-buildimage#16957 Above PR introduced "\n" in config_db, and current GNMI implementation does not support such config. How I did it Update yang validation part to read config from file. How to verify it Run GNMI end to end test.
ganglyu
added a commit
to ganglyu/sonic-gnmi
that referenced
this pull request
Jun 18, 2024
Why I did it sonic-net/sonic-buildimage#16957 Above PR introduced "\n" in config_db, and current GNMI implementation does not support such config. How I did it Update yang validation part to read config from file. How to verify it Run GNMI end to end test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Added Banner feature related services according to HLD: sonic-net/SONiC#1361
Work item tracking
How I did it
Added banner-config systemd service, YANG model for new ConfDB table and YANG model tests
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)