Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] add processor.max_cstate=1 to intel kernel cmdline #16371

Merged

Conversation

Xichen96
Copy link
Contributor

@Xichen96 Xichen96 commented Sep 1, 2023

This is a fix for PR #6051

The original PR will disable intel idle driver but it cannot limit the max c-state to 1 due to system will fall back to acpi idle driver.

Currently intel_idle.max_cstate=0 is already present, which will disable intel idle driver. With the added option, common idle driver will be disabled as well, so there will not be idle management. This is to prevent a bug that can be triggered by idle instruction on intel platform.

Why I did it

Work item tracking
  • Microsoft ADO (number only): 24867921

How I did it

Add the option to installer file beside intel_idle.max_cstate=0

How to verify it

Manually changed kernel boot option to include the new parameter and reboot.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

20201231.82,20181130.101,20220531.36

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Xichen Lin <lukelin0907@gmail.com>
@lguohan lguohan merged commit 35bb472 into sonic-net:202205 Sep 1, 2023
15 checks passed
@lguohan
Copy link
Collaborator

lguohan commented Sep 1, 2023

@Xichen96 , do you have master branch pr?

@Blueve
Copy link
Contributor

Blueve commented Sep 2, 2023

@lguohan this is master branch PR: #16339
there were some merge conflicts on branches that <= 202205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants