[minigraph] Add support for ipv4 dhcp_server in minigraph parser #16313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaqiangz
changed the title
yaqiangz
force-pushed
the
azure-master_dhcp_server_ipv4_parser
branch
from
7c8b1c4
to
8575641
Compare
yaqiangz
force-pushed
the
azure-master_dhcp_server_ipv4_parser
branch
from
8575641
to
5f0d5bb
Compare
Blueve
approved these changes
Sep 1, 2023
|
@yxieca Could you pls help to merge this PR? |
|
@qiluo-msft , i thought we are gong to block all minigraph changes now? |
qiluo-msft
reviewed
Sep 5, 2023
| results['DHCP_SERVER_IPV4'] = dhcp_server_ipv4 | ||
| if dhcp_server_ipv4_customized_options: | ||
| results['DHCP_SERVER_IPV4_CUSTOMIZED_OPTIONS'] = dhcp_server_ipv4_customized_options | ||
| results['DHCP_SERVER_IPV4_PORT'] = dhcp_server_ipv4_port |
There was a problem hiding this comment.
This is a new table in ConfigDB. Please onboard it with golden config generation pipeline. We are blocking new tables coming into minigraph parser.
qiluo-msft
reviewed
Sep 12, 2023
| @@ -2068,6 +2140,18 @@ def parse_xml(filename, platform=None, port_config_file=None, asic_name=None, hw | |||
| 'client_crt_cname': 'client.restapi.sonic' | |||
| } | |||
| } | |||
| if devices[hostname]["type"] == "BmcMgmtToRRouter": | |||
| dhcp_server_ipv4, dhcp_server_ipv4_port, dhcp_server_ipv4_customized_options = \ | |||
| generate_ipv4_dhcp_server_config(devices, link_ports, port_alias_map, vlan_intfs, vlan_members, | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add minigraph parser support for dhcp_server in BmcMgmtToRRouter device followed sonic-net/SONiC#1282. Parse dhcp_server related info from minigraph.
Work item tracking
How I did it
Add minigraph parser support for dhcp_server in BmcMgmtToRRouter device.
How to verify it
Build image, ut passed.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)