Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine PR test template format #15636

Merged
merged 6 commits into from
Jul 10, 2023

Conversation

lerry-lee
Copy link
Contributor

Why I did it

Refine PR test template format.

Work item tracking
  • Microsoft ADO (number only):24382762

How I did it

Refine PR test template format.

How to verify it

PR test executed normally.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
@lerry-lee lerry-lee requested a review from lguohan as a code owner June 27, 2023 03:38
Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
@@ -16,6 +16,10 @@ parameters:

- name: MAX_WORKER
type: string
default: 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the same min and max worker

Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
Copy link
Contributor

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pass mgmt_branch param outside of test template

Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
Pass mgmt_branch param outside of test template

Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
@wangxin wangxin merged commit c07447a into sonic-net:master Jul 10, 2023
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
Why I did it
Refine PR test template format.

How I did it
Refine PR test template format.

How to verify it
PR test executed normally.

Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants