Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the description message of PSU power threshold checking in system health #15289

Merged

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Jun 1, 2023

Why I did it

Adjust PSU power threshold logic in system health.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Update the description message in PSU power threshold checking
power of PSU x (xx w) exceeds threshold (xx w) => System power exceeds xx threshold (xx w)

How to verify it

Manual test and unit test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs changed the title PSU power threshold enhancement Update the description message of PSU power threshold checking in system health Jul 2, 2023
@stephenxs stephenxs marked this pull request as ready for review July 2, 2023 03:54
@stephenxs stephenxs requested a review from lguohan as a code owner July 2, 2023 03:54
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@liat-grozovik
Copy link
Collaborator

@prgeor , @keboliu please help to review/merge

@prgeor
Copy link
Contributor

prgeor commented Jul 11, 2023

@stephenxs I guess the 'power_critical_threshold' is per PSU and not system wide threshold?

@stephenxs
Copy link
Collaborator Author

@stephenxs I guess the 'power_critical_threshold' is per PSU and not system wide threshold?

Hi @prgeor
the power_critical_threshold is provided on a per PSU basis. But it is compared with the system power consumption instead of the PSU's power consumption.

@liat-grozovik liat-grozovik merged commit 2a55e8b into sonic-net:master Jul 14, 2023
1 check passed
@stephenxs stephenxs deleted the psu-power-threshold-enhancement branch July 15, 2023 00:26
@StormLiangMS
Copy link
Contributor

@prgeor could we have ADO for this fix?

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 14, 2023
…tem health (sonic-net#15289)

- Why I did it
Adjust PSU power threshold logic in system health.

- How I did it
Update the description message in PSU power threshold checking
power of PSU x (xx w) exceeds threshold (xx w) => System power exceeds xx threshold (xx w)

- How to verify it
Manual test and unit test
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #16131

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #16132

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 14, 2023
…tem health (sonic-net#15289)

- Why I did it
Adjust PSU power threshold logic in system health.

- How I did it
Update the description message in PSU power threshold checking
power of PSU x (xx w) exceeds threshold (xx w) => System power exceeds xx threshold (xx w)

- How to verify it
Manual test and unit test
mssonicbld pushed a commit that referenced this pull request Aug 14, 2023
…tem health (#15289)

- Why I did it
Adjust PSU power threshold logic in system health.

- How I did it
Update the description message in PSU power threshold checking
power of PSU x (xx w) exceeds threshold (xx w) => System power exceeds xx threshold (xx w)

- How to verify it
Manual test and unit test
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
…tem health (sonic-net#15289)

- Why I did it
Adjust PSU power threshold logic in system health.

- How I did it
Update the description message in PSU power threshold checking
power of PSU x (xx w) exceeds threshold (xx w) => System power exceeds xx threshold (xx w)

- How to verify it
Manual test and unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants