Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] update isc-dhcp to 4.4.1-2.3+deb11u2 to fix build failure #15002

Merged
merged 1 commit into from
May 11, 2023

Conversation

k-v1
Copy link
Contributor

@k-v1 k-v1 commented May 10, 2023

Why I did it

Fix #15000
isc-dhcp 4.4.1-2.3+deb11u1 is no longer available in debian repository

How I did it

update isc-dhcp to new version 4.4.1-2.3+deb11u2

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

@k-v1 k-v1 requested review from qiluo-msft, xumia and lguohan as code owners May 10, 2023 09:47
@patilshashidhar
Copy link

You may see gpg verification error caused by absence of the package signing gpg key.

isc-dhcp_4.4.1-2.3+deb11u2.dsc:
dscverify: isc-dhcp_4.4.1-2.3+deb11u2.dsc failed signature check:
gpg: WARNING: no command supplied. Trying to guess what you mean ...
gpg: Signature made Mon Feb 20 08:30:27 2023 UTC
gpg: using EDDSA key 3CA442833488100C04033811638B46815BBB308F
gpg: Can't check signature: No public key
gpg: can't create `/var/sananajk/.gnupg/random_seed': No such file or directory
Validation FAILED!!

@k-v1
Copy link
Contributor Author

k-v1 commented May 10, 2023

You may see gpg verification error caused by absence of the package signing gpg key.

That's why -u flag was added for dget:

       -u, --allow-unauthenticated
           Do not attempt to verify the integrity of downloaded source
           packages using dscverify.

This flag is already used for some packages like lm-sensors or bash.
Also sources of other packages are downloaded via wget.
I think this validation is useless if it's not enabled for all packages.
So we can disable it for this package too.

Copy link
Contributor

@liushilongbuaa liushilongbuaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@liushilongbuaa
Copy link
Contributor

202211 branch needs this PR.

@xumia
Copy link
Collaborator

xumia commented May 11, 2023

Is there a way to only allow expired signature when unauthenticated?

@k-v1
Copy link
Contributor Author

k-v1 commented May 11, 2023

Is there a way to only allow expired signature when unauthenticated?

I can try to investigate this later.

But I think better to implement another solution for web files someday.
Maybe special files with hashes of downloaded files like rules/isc-dhcp.hash containing md5 or sha256 of dsc file.
In this case we can validate files even with expired signatures.

@k-v1
Copy link
Contributor Author

k-v1 commented May 11, 2023

Is there a way to only allow expired signature when unauthenticated?

The keyrings maintained by the keyring-maint team are packaged in Debian as debian-keyring. This package is often not the most up to date version of the keyring, though it can be a good way to bootstrap trust if you trust the media you installed Debian from as the package will be verified using GnuPG when it is downloaded and installed. The installed keyrings are placed in /usr/share/keyrings.

We can install new version of debian-keyring via rsync and overwrite old files:
sudo rsync -az keyring.debian.org::keyrings/keyrings/ /usr/share/keyrings
In this case we get:

isc-dhcp_4.4.1-2.3+deb11u2.dsc:
      Good signature found
   validating isc-dhcp_4.4.1.orig.tar.gz
   validating isc-dhcp_4.4.1-2.3+deb11u2.debian.tar.xz
All files validated successfully.

But in theory it can break something else.
Maybe better solution now is just ignore a signature for isc-dhcp package.

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit ee1ab44 into sonic-net:master May 11, 2023
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request May 11, 2023
…nic-net#15002)

Why I did it
Fix sonic-net#15000
isc-dhcp 4.4.1-2.3+deb11u1 is no longer available in debian repository

How I did it
update isc-dhcp to new version 4.4.1-2.3+deb11u2
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #15022

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #15171

lukasstockner pushed a commit to genesiscloud/sonic-buildimage that referenced this pull request Jun 29, 2023
volodymyrsamotiy pushed a commit to volodymyrsamotiy/sonic-buildimage that referenced this pull request Sep 26, 2023
…15002)

Why I did it
Fix sonic-net#15000
isc-dhcp 4.4.1-2.3+deb11u1 is no longer available in debian repository

How I did it
update isc-dhcp to new version 4.4.1-2.3+deb11u2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SONiC image build error caused by isc-dhcp package build failure
7 participants