-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ci] Support to use the same snapshot for all platform builds #13913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liushilongbuaa
approved these changes
Feb 22, 2023
StormLiangMS
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 22, 2023
Cherry-pick PR to 202211: #13917 |
The commit message is not correct, caused by copy & paste issue. |
mssonicbld
added a commit
that referenced
this pull request
Feb 22, 2023
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
Feb 22, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 22, 2023
Cherry-pick PR to 202205: #13938 |
mssonicbld
added a commit
that referenced
this pull request
Feb 23, 2023
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
labels
Feb 23, 2023
8 tasks
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Apr 7, 2023
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Apr 14, 2023
10 tasks
10 tasks
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Apr 14, 2023
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Apr 17, 2023
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Apr 17, 2023
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Apr 17, 2023
xumia
added a commit
that referenced
this pull request
Apr 18, 2023
…lity (#14663) Why I did it Cherry-pick commits from master to support the snapshot based mirror, and fix the code conflicts. ad162ae [Build] Optimize the version control for Debian packages (#14557) 38c5d7f [Build] Support j2 template for debian sources for docker ptf (#13198) 5e4826e [Ci] Support to use the same snapshot for all platform builds (#13913) 8206925 [Build] Change the default mirror version config file (#13786) 5e4a866 [Build] Support Debian snapshot mirror to improve build stability (#13097) ac5d89c [Build] Support j2 template for debian sources (#12557) Work item tracking Microsoft ADO (number only): 18018114 How I did it How to verify it
xumia
added a commit
that referenced
this pull request
Apr 18, 2023
…lity (#14664) Why I did it Cherry-pick commits from master to support the snapshot based mirror, and fix the code conflicts. ad162ae [Build] Optimize the version control for Debian packages (#14557) 38c5d7f [Build] Support j2 template for debian sources for docker ptf (#13198) 5e4826e [Ci] Support to use the same snapshot for all platform builds (#13913) 8206925 [Build] Change the default mirror version config file (#13786) 5e4a866 [Build] Support Debian snapshot mirror to improve build stability (#13097) ac5d89c [Build] Support j2 template for debian sources (#12557) Work item tracking Microsoft ADO (number only): 18018114 How I did it How to verify it
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Apr 20, 2023
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Apr 20, 2023
qiluo-msft
pushed a commit
that referenced
this pull request
Apr 21, 2023
…lity (#14558) #### Why I did it Cherry-pick commits from master to support the snapshot based mirror, and fix the code conflicts. And add the last commit to fix the build broken issue according to the mirror change. ad162ae [Build] Optimize the version control for Debian packages (#14557) 38c5d7f [Build] Support j2 template for debian sources for docker ptf (#13198) 5e4826e [Ci] Support to use the same snapshot for all platform builds (#13913) 8206925 [Build] Change the default mirror version config file (#13786) 5e4a866 [Build] Support Debian snapshot mirror to improve build stability (#13097) ac5d89c [Build] Support j2 template for debian sources (#12557)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Support to use the same snapshot for all platform builds.
There are multiple builds for the different platforms, such as vs, broadcom, mellanox, etc. The jobs to build each of the platform are not triggered at the same time, depended on if the agents are ready or not. The builds may use different snapshots, and use different version of a package, it is not a desired behavior.
How I did it
Added another stage to prepare the snapshot version, make sure all the builds using the same snapshot.
Backport to 202205/202211 which support the snapshot based build.
How to verify it
Created a self pipeline to verify it, see https://dev.azure.com/mssonic/build/_build/results?buildId=222340&view=logs&j=cef3d8a9-152e-5193-620b-567dc18af272&t=b9010a6b-c6d1-5dc2-a48b-b94374f4e7e6
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)