Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ci] Support to use the same snapshot for all platform builds #13913

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

xumia
Copy link
Collaborator

@xumia xumia commented Feb 22, 2023

Why I did it

Support to use the same snapshot for all platform builds.
There are multiple builds for the different platforms, such as vs, broadcom, mellanox, etc. The jobs to build each of the platform are not triggered at the same time, depended on if the agents are ready or not. The builds may use different snapshots, and use different version of a package, it is not a desired behavior.

How I did it

Added another stage to prepare the snapshot version, make sure all the builds using the same snapshot.
Backport to 202205/202211 which support the snapshot based build.

How to verify it

Created a self pipeline to verify it, see https://dev.azure.com/mssonic/build/_build/results?buildId=222340&view=logs&j=cef3d8a9-152e-5193-620b-567dc18af272&t=b9010a6b-c6d1-5dc2-a48b-b94374f4e7e6

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@xumia xumia requested a review from liushilongbuaa February 22, 2023 00:57
Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xumia xumia merged commit 5e4826e into sonic-net:master Feb 22, 2023
@xumia xumia deleted the set-snapshot-verison branch February 22, 2023 03:18
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Feb 22, 2023
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #13917

@xumia
Copy link
Collaborator Author

xumia commented Feb 22, 2023

The commit message is not correct, caused by copy & paste issue.

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #13938

xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 7, 2023
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 14, 2023
@xumia xumia mentioned this pull request Apr 14, 2023
10 tasks
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 14, 2023
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 17, 2023
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 17, 2023
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 17, 2023
xumia added a commit that referenced this pull request Apr 18, 2023
…lity (#14663)

Why I did it
Cherry-pick commits from master to support the snapshot based mirror, and fix the code conflicts.

ad162ae [Build] Optimize the version control for Debian packages (#14557)
38c5d7f [Build] Support j2 template for debian sources for docker ptf (#13198)
5e4826e [Ci] Support to use the same snapshot for all platform builds (#13913)
8206925 [Build] Change the default mirror version config file (#13786)
5e4a866 [Build] Support Debian snapshot mirror to improve build stability (#13097)
ac5d89c [Build] Support j2 template for debian sources (#12557)

Work item tracking
Microsoft ADO (number only): 18018114
How I did it
How to verify it
xumia added a commit that referenced this pull request Apr 18, 2023
…lity (#14664)

Why I did it
Cherry-pick commits from master to support the snapshot based mirror, and fix the code conflicts.

ad162ae [Build] Optimize the version control for Debian packages (#14557)
38c5d7f [Build] Support j2 template for debian sources for docker ptf (#13198)
5e4826e [Ci] Support to use the same snapshot for all platform builds (#13913)
8206925 [Build] Change the default mirror version config file (#13786)
5e4a866 [Build] Support Debian snapshot mirror to improve build stability (#13097)
ac5d89c [Build] Support j2 template for debian sources (#12557)

Work item tracking
Microsoft ADO (number only): 18018114
How I did it
How to verify it
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 20, 2023
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 20, 2023
qiluo-msft pushed a commit that referenced this pull request Apr 21, 2023
…lity (#14558)

#### Why I did it
Cherry-pick commits from master to support the snapshot based mirror, and fix the code conflicts. And add the last commit to fix the build broken issue according to the mirror change.

ad162ae [Build] Optimize the version control for Debian packages (#14557)
38c5d7f [Build] Support j2 template for debian sources for docker ptf (#13198)
5e4826e  [Ci] Support to use the same snapshot for all platform builds (#13913)
8206925 [Build] Change the default mirror version config file (#13786)
5e4a866 [Build] Support Debian snapshot mirror to improve build stability (#13097)
ac5d89c  [Build] Support j2 template for debian sources (#12557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants