Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-picked snmp sonic-yang file from 2bb8306d8e20d798f89535eff9ab… #13896

Merged
merged 1 commit into from
Feb 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sonic-yang-models/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ def run(self):
'./yang-models/sonic-route-map.yang',
'./yang-models/sonic-routing-policy-sets.yang',
'./yang-models/sonic-sflow.yang',
'./yang-models/sonic-snmp.yang',
'./yang-models/sonic-syslog.yang',
'./yang-models/sonic-system-aaa.yang',
'./yang-models/sonic-system-tacacs.yang',
Expand Down Expand Up @@ -189,6 +190,7 @@ def run(self):
'./cvlyang-models/sonic-route-map.yang',
'./cvlyang-models/sonic-routing-policy-sets.yang',
'./cvlyang-models/sonic-sflow.yang',
'./cvlyang-models/sonic-snmp.yang',
'./cvlyang-models/sonic-system-aaa.yang',
'./cvlyang-models/sonic-system-tacacs.yang',
'./cvlyang-models/sonic-telemetry.yang',
Expand Down
18 changes: 17 additions & 1 deletion src/sonic-yang-models/tests/files/sample_config_db.json
Original file line number Diff line number Diff line change
Expand Up @@ -1908,8 +1908,24 @@
"LAG"
]
}
},
},

"SNMP": {
"CONTACT": {
"Contact": "testuser@contoso.com"
},
"LOCATION": {
"Location": "SNMP Server Location"
}
},
"SNMP_COMMUNITY": {
"public": {
"TYPE": "RO"
},
"private": {
"TYPE": "RW"
}
},
"LOSSLESS_TRAFFIC_PATTERN": {
"AZURE": {
"mtu": "1024",
Expand Down
28 changes: 28 additions & 0 deletions src/sonic-yang-models/tests/yang_model_tests/tests/snmp.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"SNMP_SYSTEM_TEST": {
"desc": "Load SNMP sysContact and sysLocation."
},
"SNMP_SYSTEM_CONTACT_NEG_TEST": {
"desc": "Load SNMP sysContact with empty string",
"eStrKey": "Range"
},
"SNMP_SYSTEM_LOCATION_NEG_TEST": {
"desc": "Load SNMP sysContact with empty string",
"eStrKey": "Range"
},
"SNMP_COMMUNITY_TEST": {
"desc": "Load SNMP community string."
},
"SNMP_COMMUNITY_MIN_NEG_TEST": {
"desc": "Load SNMP community string of length < 3.",
"eStrKey": "Range"
},
"SNMP_COMMUNITY_MAX_NEG_TEST": {
"desc": "Load SNMP community string of lenth > 32.",
"eStrKey": "Range"
},
"SNMP_COMMUNITY_WRONG_TYPE_TEST": {
"desc": "Load SNMP community string with un supported type.",
"eStrKey": "InvalidValue"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
{
"SNMP_SYSTEM_TEST": {
"sonic-snmp:sonic-snmp": {
"sonic-snmp:SNMP": {
"CONTACT": {
"Contact": "support@xyz.com"
},
"LOCATION": {
"Location": "Test location"
}
}
}
},
"SNMP_SYSTEM_CONTACT_NEG_TEST": {
"sonic-snmp:sonic-snmp": {
"sonic-snmp:SNMP": {
"CONTACT": {
"Contact": ""
}
}
}
},
"SNMP_SYSTEM_LOCATION_NEG_TEST": {
"sonic-snmp:sonic-snmp": {
"sonic-snmp:SNMP": {
"LOCATION": {
"Location": ""
}
}
}
},

"SNMP_COMMUNITY_TEST": {
"sonic-snmp:sonic-snmp": {
"sonic-snmp:SNMP_COMMUNITY": {
"SNMP_COMMUNITY_LIST": [
{
"name": "sonicSnmp",
"TYPE": "RO"
},
{
"name": "sonicSnmpRW",
"TYPE": "RW"
}
]
}
}
},
"SNMP_COMMUNITY_MIN_NEG_TEST": {
"sonic-snmp:sonic-snmp": {
"sonic-snmp:SNMP_COMMUNITY": {
"SNMP_COMMUNITY_LIST": [
{
"name": "abc"
}
]
}
}
},
"SNMP_COMMUNITY_MAX_NEG_TEST": {
"sonic-snmp:sonic-snmp": {
"sonic-snmp:SNMP_COMMUNITY": {
"SNMP_COMMUNITY_LIST": [
{
"name": "01234567890123456789012345678901234"
}
]
}
}
},
"SNMP_COMMUNITY_WRONG_TYPE_TEST": {
"sonic-snmp:sonic-snmp": {
"sonic-snmp:SNMP_COMMUNITY": {
"SNMP_COMMUNITY_LIST": [
{
"name": "sonicSnmp",
"TYPE": "RR"
}
]
}
}
}
}
74 changes: 74 additions & 0 deletions src/sonic-yang-models/yang-models/sonic-snmp.yang
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
module sonic-snmp {
namespace "http://github.com/Azure/sonic-snmp";
prefix ssnmp;
yang-version 1.1;


organization
"SONiC";

contact
"SONiC";

description
"SONIC SNMP";

revision 2022-05-13 {
description
"Initial revision.";
}


container sonic-snmp {

container SNMP {
container CONTACT {
leaf Contact {
type string {
length "1..255";
}
description
"SNMP System Contact.";
}
}
container LOCATION {
leaf Location {
type string {
length "1..255";
}
description
"SNMP System Location.";
}

}
}

container SNMP_COMMUNITY {
list SNMP_COMMUNITY_LIST {
key name;
description
"List of communities.";

leaf name {
type string {
length "4..32";
pattern '[^ @,\\' +"']*" {
error-message 'Invalid snmp community string (Valid chars are ASCII printable except SPACE, single quote,"@", "," and "\")';
}
}
description
"Index into the community list which must be the community name.";
}

leaf TYPE {
type enumeration {
enum RO;
enum RW;
}
description
"Type of community, read-only or read-write.";
}
}
}
}
}