Updated PR Template for a comment to add label/tag for the feature #12058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ised. Signed-off-by: kannankvs <kannan_kvs@dell.com>
lguohan
approved these changes
Sep 14, 2022
qiluo-msft
reviewed
Sep 27, 2022
| @@ -39,6 +39,8 @@ Write a short (one line) summary that describes the changes in this | |||
| pull request for inclusion in the changelog: | |||
| --> | |||
|
|
|||
| #### Ensure to add label/tag for the feature raised. example - [PR#2174](https://github.com/sonic-net/sonic-utilities/pull/2174) where, Generic Config and Update feature has been labelled as GCU. | |||
There was a problem hiding this comment.
The example PR link actually link all future PRs to the sonic-utilities PR 2174 , and will lead to very long noise history in that PR. Please fix ASAP.
There was a problem hiding this comment.
As suggested, the example PR link has been removed and reference is given as text. And PR#12276 has been raised for the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ised.
Signed-off-by: kannankvs kannan_kvs@dell.com
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)