Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mux] skip mux operations during warm shutdown #11937

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Sep 1, 2022

Why I did it

MuX related operations are not warm reboot ready previously.

How I did it

  • Enhance write_standby.py script to skip actions during warm shutdown.
  • Expand the support to BGP service.
  • MuX support was added by a previous PR.
  • Addressed a bug: the action should not be skipped during warm recovery.

How to verify it

Run test on device with following settings and validate behavior is expected:

  • warm reboot/restart is not enabled.
  • system level warm reboot is enabled.
  • bgp warm restart was enabled.
  • mux warm restart was enabled.

Signed-off-by: Ying Xie ying.xie@microsoft.com

- Enhance write_standby.py script to skip actions during warm shutdown.
- Expand the support to BGP service.
- MuX support was added by a previous PR.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yejianquan
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@yejianquan
Copy link
Contributor

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca yxieca merged commit a684392 into sonic-net:master Sep 2, 2022
@yxieca yxieca deleted the write_standby branch September 2, 2022 20:50
@qiluo-msft
Copy link
Collaborator

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

yxieca added a commit that referenced this pull request Sep 8, 2022
* [mux] skip mux operations during warm shutdown

- Enhance write_standby.py script to skip actions during warm shutdown.
- Expand the support to BGP service.
- MuX support was added by a previous PR.
- don't skip action during warm recovery

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca
Copy link
Contributor Author

yxieca commented Oct 3, 2022

@qiluo-msft, please cherry-pick #11937 before cherry-picking this PR.

qiluo-msft pushed a commit that referenced this pull request Oct 3, 2022
* [mux] skip mux operations during warm shutdown

- Enhance write_standby.py script to skip actions during warm shutdown.
- Expand the support to BGP service.
- MuX support was added by a previous PR.
- don't skip action during warm recovery

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants