Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pmon] Add ping package to pmon docker #11550

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

amulyan7
Copy link
Contributor

@amulyan7 amulyan7 commented Jul 27, 2022

Why I did it

ping command is not working inside PMON docker (bullseye)
Use case: chassisd checks for module reachability inside PMON for "show chassis modules midplane-status" CLI, and on Cisco chassis, this uses ping command to check network reachability

How I did it

Add iputils-ping package in pmon dockerfile

How to verify it

Run ping command inside PMON container

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

[pmon] Add ping package to pmon docker

A picture of a cute animal (not mandatory but encouraged)

pexels-pixabay-162140

@amulyan7 amulyan7 requested a review from lguohan as a code owner July 27, 2022 18:10
@amulyan7 amulyan7 changed the title Add ping package to pmon docker [pmon] Add ping package to pmon docker Jul 27, 2022
@anamehra
Copy link
Contributor

Hi @abdosi , please review. Thanks

@abdosi
Copy link
Contributor

abdosi commented Jul 27, 2022

can you explain the use case of having ping in pmon in above why section ?

@abdosi abdosi requested a review from saiarcot895 July 27, 2022 18:29
@amulyan7
Copy link
Contributor Author

can you explain the use case of having ping in pmon in above why section ?

Sure, updated the description

@amulyan7
Copy link
Contributor Author

@abdosi Looks like some tests failed (shows on SSH connection), can we try a rerun?

@amulyan7
Copy link
Contributor Author

@abdosi All checks shows as passed, can we go ahead and merge it if everything looks good?

@amulyan7
Copy link
Contributor Author

amulyan7 commented Aug 3, 2022

@abdosi Any update on this PR?

@abdosi abdosi merged commit 1b33f86 into sonic-net:master Aug 3, 2022
yxieca pushed a commit that referenced this pull request Aug 8, 2022
ping command is not working inside PMON docker (bullseye)
Use case: chassisd checks for module reachability inside PMON for "show chassis modules midplane-status" CLI, and on Cisco chassis, this uses ping command to check network reachability
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
ping command is not working inside PMON docker (bullseye)
Use case: chassisd checks for module reachability inside PMON for "show chassis modules midplane-status" CLI, and on Cisco chassis, this uses ping command to check network reachability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants