Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase LAG Ids to 1024 #10519

Merged
merged 5 commits into from
Apr 27, 2023
Merged

Increase LAG Ids to 1024 #10519

merged 5 commits into from
Apr 27, 2023

Conversation

ysmanman
Copy link
Contributor

@ysmanman ysmanman commented Apr 9, 2022

Why I did it

Today at most 128 LAGs are supported. This is not sufficient if there are many LAGs with just few ports.

How I did it

Increase LAG Ids to 1024 for DNX device.

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rlhui rlhui added the Chassis 🤖 Modular chassis support label Jun 8, 2022
@rlhui
Copy link
Contributor

rlhui commented Jun 8, 2022

@ysmanman - could you check why test is failing and resolve?

@kenneth-arista kenneth-arista mentioned this pull request Jun 8, 2022
Merged
@ysmanman ysmanman requested a review from a team as a code owner June 10, 2022 02:01
arlakshm pushed a commit that referenced this pull request Jul 6, 2022
@kenneth-arista
[Arista] Enable larger number of LAGs on 7800 LCs (#11070)
a4b9838 
For 7800 LCs, set LAG mode to support 1024 number of 16-member system
LAGs.

Why I did it
The SOC property changes are necessary to match #10519 which increases the number of system LAG IDs to 1024.

Description for the changelog
For 7800 LCs, set LAG mode to support 1024 number of 16-member system
LAGs.
yxieca pushed a commit that referenced this pull request Aug 8, 2022
@kenneth-arista @yxieca
[Arista] Enable larger number of LAGs on 7800 LCs (#11070)
2280f38 
For 7800 LCs, set LAG mode to support 1024 number of 16-member system
LAGs.

Why I did it
The SOC property changes are necessary to match #10519 which increases the number of system LAG IDs to 1024.

Description for the changelog
For 7800 LCs, set LAG mode to support 1024 number of 16-member system
LAGs.
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
@kenneth-arista @skbarista
[Arista] Enable larger number of LAGs on 7800 LCs (sonic-net#11070)
7ddbec8 
For 7800 LCs, set LAG mode to support 1024 number of 16-member system
LAGs.

Why I did it
The SOC property changes are necessary to match sonic-net#10519 which increases the number of system LAG IDs to 1024.

Description for the changelog
For 7800 LCs, set LAG mode to support 1024 number of 16-member system
LAGs.
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Sep 23, 2022
@yxieca
Merged PR 6324192: Manual merge github master into internal branch
002411d 
Related work items: sonic-net#284, sonic-net#288, sonic-net#624, sonic-net#630, sonic-net#640, sonic-net#2164, sonic-net#2206, sonic-net#2207, sonic-net#2233, sonic-net#2234, sonic-net#2238, sonic-net#8857, sonic-net#10034, sonic-net#10519, sonic-net#10685, sonic-net#10711, sonic-net#10987, sonic-net#10990, sonic-net#11047, sonic-net#11070, sonic-net#11117, sonic-net#11186, sonic-net#11207, sonic-net#11213, sonic-net#11215, sonic-net#11220, sonic-net#11221, sonic-net#11257, sonic-net#11291, sonic-net#11298, sonic-net#11301, sonic-net#11326, sonic-net#11333, sonic-net#11335, sonic-net#11341, sonic-net#11344, sonic-net#11347, sonic-net#11359, sonic-net#11366, sonic-net#11368, sonic-net#11370, sonic-net#11372, sonic-net#11375, sonic-net#11385, sonic-net#11386, sonic-net#11394, sonic-net#11397, sonic-net#11401, sonic-net#11402, sonic-net#11403, sonic-net#11405, sonic-net#11414
@arlakshm
Copy link
Contributor

/Azp Azure.sonic-buildimage

@azure-pipelines
Copy link

Command 'Azure.sonic-buildimage' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@arlakshm
Copy link
Contributor

/Azp Azure.sonic-buildimage

@azure-pipelines
Copy link

Command 'Azure.sonic-buildimage' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@arlakshm
Copy link
Contributor

/Azp Azure.sonic-buildimage

@azure-pipelines
Copy link

Command 'Azure.sonic-buildimage' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ysmanman
Copy link
Contributor Author

/Azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 10519 in repo sonic-net/sonic-buildimage

@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lguohan lguohan merged commit 48ed53c into sonic-net:master Apr 27, 2023
@ysmanman
Copy link
Contributor Author

ysmanman commented Sep 9, 2023

Hi @arlakshm , I think we need to cherry-pick this PR into 202205.

@kenneth-arista
Copy link
Contributor

@arlakshm gentle ping as this is required to address #14271

@rlhui
Copy link
Contributor

rlhui commented Sep 20, 2023

@arlakshm please add a MSFT ADO for the cherry-pick request

@arlakshm
Copy link
Contributor

MSFT ADO 25260643

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Nov 20, 2023
@ysmanman @mssonicbld
[chassis/arista]: Increase LAG Ids to 1024 (sonic-net#10519)
204ff3d 
Why I did it
Today at most 128 LAGs are supported. This is not sufficient if there are many LAGs with just few ports.

How I did it
Increase LAG Ids to 1024 for DNX device.
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Nov 20, 2023
@ysmanman @mssonicbld
[chassis/arista]: Increase LAG Ids to 1024 (sonic-net#10519)
b11ce5b 
Why I did it
Today at most 128 LAGs are supported. This is not sufficient if there are many LAGs with just few ports.

How I did it
Increase LAG Ids to 1024 for DNX device.
@arlakshm arlakshm mentioned this pull request Nov 29, 2023
Merged
11 tasks
@gechiang
Copy link
Collaborator

Adding a note here that the reason this change was not requested for 202305 branch is because this change is already present in 202305.

yxieca pushed a commit that referenced this pull request Nov 30, 2023
@mssonicbld @ysmanman
[chassis/arista]: Increase LAG Ids to 1024 (#10519) (#17241)
c18b3f9 
Why I did it
Today at most 128 LAGs are supported. This is not sufficient if there are many LAGs with just few ports.

How I did it
Increase LAG Ids to 1024 for DNX device.

Co-authored-by: Song Yuan <64041228+ysmanman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@arlakshm arlakshm arlakshm approved these changes

@sujinmkang sujinmkang Awaiting requested review from sujinmkang

@prgeor prgeor Awaiting requested review from prgeor

@vdahiya12 vdahiya12 Awaiting requested review from vdahiya12

Assignees
No one assigned
Labels
Approved for 202211 Branch Chassis 🤖 Modular chassis support Included in 202205 Branch Request for 202205 Branch Request for 202211 Branch
Projects
SONiC Chassis
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ysmanman @arlakshm @rlhui @kenneth-arista @gechiang @lguohan @yxieca