log_ssd_health timeouts when executing from shell and during warm-reboot #9114
Assignees
Comments
|
@yxieca FYI |
|
@dgsudharsan Thanks so much for pointing this out. I'll add a fix soon. |
|
@yxieca I have raised a fix for it. sonic-net/sonic-utilities#1904 If you can review it would be great. |
yxieca
pushed a commit
to sonic-net/sonic-utilities
that referenced
this issue
Oct 29, 2021
What I did Fix sonic-net/sonic-buildimage#9114 The log_ssd_health command hangs due to timeout being used with docker exec -i which also affect warmboot flow. How I did it Added foreground option for timeout. This is recommended when not using the command on shell https://man7.org/linux/man-pages/man1/timeout.1.html How to verify it Run log_ssd_health and verify it does not hang Signed-off-by: Sudharsan Dhamal Gopalarathnam sudharsand@nvidia.com
qiluo-msft
pushed a commit
to sonic-net/sonic-utilities
that referenced
this issue
Nov 5, 2021
What I did Fix sonic-net/sonic-buildimage#9114 The log_ssd_health command hangs due to timeout being used with docker exec -i which also affect warmboot flow. How I did it Added foreground option for timeout. This is recommended when not using the command on shell https://man7.org/linux/man-pages/man1/timeout.1.html How to verify it Run log_ssd_health and verify it does not hang Signed-off-by: Sudharsan Dhamal Gopalarathnam sudharsand@nvidia.com
judyjoseph
pushed a commit
to sonic-net/sonic-utilities
that referenced
this issue
Nov 6, 2021
What I did Fix sonic-net/sonic-buildimage#9114 The log_ssd_health command hangs due to timeout being used with docker exec -i which also affect warmboot flow. How I did it Added foreground option for timeout. This is recommended when not using the command on shell https://man7.org/linux/man-pages/man1/timeout.1.html How to verify it Run log_ssd_health and verify it does not hang Signed-off-by: Sudharsan Dhamal Gopalarathnam sudharsand@nvidia.com
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this issue
Aug 3, 2023
What I did Fix sonic-net/sonic-buildimage#9114 The log_ssd_health command hangs due to timeout being used with docker exec -i which also affect warmboot flow. How I did it Added foreground option for timeout. This is recommended when not using the command on shell https://man7.org/linux/man-pages/man1/timeout.1.html How to verify it Run log_ssd_health and verify it does not hang Signed-off-by: Sudharsan Dhamal Gopalarathnam sudharsand@nvidia.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Issue introduced after sonic-net/sonic-utilities#1850
timeout command was added to smartctl. However, the smartctl command in host is a wrapper which calls docker exec -it pmon smartctl. With the interactive mode, the command doesn't return and it times out. This is documented in the bug moby/moby#28207 (comment) and recommendation is to use --foreground in timeout command which solves the issue
In the below logs between successive commands the log_sdd_health takes 30 seconds and timeouts
Oct 20 09:19:23.134719 arc-switch1025 NOTICE admin: Collecting logs to check ssd health before fast-reboot...
Oct 20 09:19:53.154005 arc-switch1025 NOTICE admin: Stopping nat ...
Steps to reproduce the issue:
Describe the results you received:
The command hangs
Describe the results you expected:
The command shouldn't hang
Output of
show version:Output of
show techsupport:Additional information you deem important (e.g. issue happens only occasionally):
The text was updated successfully, but these errors were encountered: