-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fwutil show
command has conflicting subcommands
#8924
Labels
Triaged
this issue has been triaged
Comments
@sujinmkang FYI |
qiluo-msft
pushed a commit
to sonic-net/sonic-utilities
that referenced
this issue
Apr 29, 2022
…ot fw update (#2040) sonic-net/sonic-buildimage#8928 sonic-net/sonic-buildimage#8926 sonic-net/sonic-buildimage#8925 sonic-net/sonic-buildimage#8924 #### What I did Allow fwutil update all for other boot type if any previous fw update done for "none" boot type #### How I did it Allow fwutil update all for other boot type if any previous fw update done for "none" boot type #### How to verify it 1. Run fwutil update all for boot_type="none" 2. Run fwutil update all for any other boot_type 3. Verify if the 2nd update is proceeded.
judyjoseph
pushed a commit
to sonic-net/sonic-utilities
that referenced
this issue
May 2, 2022
…ot fw update (#2040) sonic-net/sonic-buildimage#8928 sonic-net/sonic-buildimage#8926 sonic-net/sonic-buildimage#8925 sonic-net/sonic-buildimage#8924 #### What I did Allow fwutil update all for other boot type if any previous fw update done for "none" boot type #### How I did it Allow fwutil update all for other boot type if any previous fw update done for "none" boot type #### How to verify it 1. Run fwutil update all for boot_type="none" 2. Run fwutil update all for any other boot_type 3. Verify if the 2nd update is proceeded.
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this issue
Aug 3, 2023
…ot fw update (#2040) sonic-net/sonic-buildimage#8928 sonic-net/sonic-buildimage#8926 sonic-net/sonic-buildimage#8925 sonic-net/sonic-buildimage#8924 #### What I did Allow fwutil update all for other boot type if any previous fw update done for "none" boot type #### How I did it Allow fwutil update all for other boot type if any previous fw update done for "none" boot type #### How to verify it 1. Run fwutil update all for boot_type="none" 2. Run fwutil update all for any other boot_type 3. Verify if the 2nd update is proceeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
There are two conflicting sub-commands defined for
fwutil show
One was recently added here: https://github.com/Azure/sonic-utilities/blob/1029c5487dd1190215dae6ca557d6feb96113c9d/fwutil/main.py#L465
The other was added originally here: https://github.com/Azure/sonic-utilities/blob/1029c5487dd1190215dae6ca557d6feb96113c9d/fwutil/main.py#L406
These are causing issues with the tab-complete CLI helper.
Steps to reproduce the issue:
fwutil show
tab
Describe the results you received:
Describe the results you expected:
The text was updated successfully, but these errors were encountered: