Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multi-asic] show acl table command gets data from host config db and not from asic namespace db #16012

Closed
judyjoseph opened this issue Aug 1, 2023 · 0 comments · Fixed by sonic-net/sonic-utilities#2937
Assignees
Labels
Chassis 🤖 Modular chassis support MSFT Triaged this issue has been triaged

Comments

@judyjoseph
Copy link
Contributor

Description

"show acl table" which uses acl-loader gets data from host config db alone for multi-asic devices. The ACL entries in host need not have all the interfaces which is valid in the namespaces.

Instead we need to connect to each namespace and get the ACLs

Steps to reproduce the issue:

  1. show acl table DATAACL

Describe the results you received:

admin@str2--lc1-1:~$ show acl table DATAACL
Name     Type    Binding         Description    Stage    Status
-------  ------  --------------  -------------  -------  --------------------------------------
DATAACL  L3      PortChannel102 DATAACL        ingress  {'asic0': 'Active', 'asic1': 'Active'}
                 PortChannel106

Describe the results you expected:

admin@str2--lc1-1:~$ show acl table DATAACL
Name     Type    Binding         Description    Stage    Status
-------  ------  --------------  -------------  -------  --------------------------------------
DATAACL  L3      Ethernet128     DATAACL        ingress  {'asic0': 'Active', 'asic1': 'Active'}
                 Ethernet184
                 PortChannel102
                 PortChannel106

Output of show version:

admin@str2--lc1-1:~$ show version 

SONiC Software Version: SONiC.20220530.38
SONiC OS Version: 11
Distribution: Debian 11.7
Kernel: 5.10.0-18-2-amd64
Build commit: 4115919589
Build date: Fri Jul 28 01:24:14 UTC 2023
Built by: cloudtest@8ec96c8ac000000```
#### Output of `show techsupport`:

(paste your output here or download and attach the file here )


#### Additional information you deem important (e.g. issue happens only occasionally):

<!--
     Also attach debug file produced by `sudo generate_dump`
-->
@judyjoseph judyjoseph changed the title [multi-asic] show acl table reading from host config db alone [multi-asic] show acl table command gets data from host config db and not from asic namespace db Aug 2, 2023
@lguohan lguohan added the Chassis 🤖 Modular chassis support label Aug 2, 2023
@neethajohn neethajohn added Triaged this issue has been triaged MSFT labels Aug 2, 2023
@arlakshm arlakshm self-assigned this Aug 2, 2023
rlhui pushed a commit to sonic-net/sonic-utilities that referenced this issue Aug 18, 2023
What I did
Fixes sonic-net/sonic-buildimage#16012
The show acl table command currently get the ports from host config_db on multi asic platforms.
This host config_db will not the phyiscal ports in the binding ports because the host doesnt have any front panel ports on the host. This causes the show acl table not to display the phyiscal ports in the output on multi asic devices/linecards.

The test iface_namingmode/test_iface_namingmode.py::test_show_acl_table fails because of this issue.
yxieca pushed a commit to sonic-net/sonic-utilities that referenced this issue Sep 6, 2023
What I did
Fixes sonic-net/sonic-buildimage#16012
The show acl table command currently get the ports from host config_db on multi asic platforms.
This host config_db will not the phyiscal ports in the binding ports because the host doesnt have any front panel ports on the host. This causes the show acl table not to display the phyiscal ports in the output on multi asic devices/linecards.

The test iface_namingmode/test_iface_namingmode.py::test_show_acl_table fails because of this issue.
StormLiangMS pushed a commit to sonic-net/sonic-utilities that referenced this issue Sep 21, 2023
What I did
Fixes sonic-net/sonic-buildimage#16012
The show acl table command currently get the ports from host config_db on multi asic platforms.
This host config_db will not the phyiscal ports in the binding ports because the host doesnt have any front panel ports on the host. This causes the show acl table not to display the phyiscal ports in the output on multi asic devices/linecards.

The test iface_namingmode/test_iface_namingmode.py::test_show_acl_table fails because of this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chassis 🤖 Modular chassis support MSFT Triaged this issue has been triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants