Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yang model unit test for check_up_status field type #11110

Closed
qiluo-msft opened this issue Jun 10, 2022 · 4 comments
Closed

Add yang model unit test for check_up_status field type #11110

qiluo-msft opened this issue Jun 10, 2022 · 4 comments
Assignees
@sg893052
Labels
Triaged this issue has been triaged YANG YANG model related changes

Comments

@qiluo-msft
Copy link
Collaborator

Could you add yang model unit test?
We recently fixed a bug #10986

Originally posted by @qiluo-msft in #10479 (comment)
@qiluo-msft
Copy link
Collaborator Author

@sg893052 Could you help this issue?

@sg893052
Copy link
Contributor

sg893052 commented Jun 13, 2022 •
edited
Loading

Sure, I can push the yang model UT change once #10986 gets merged.
Thanks!

@yxieca yxieca added Triaged this issue has been triaged YANG YANG model related changes labels Jun 22, 2022
This was referenced Jun 24, 2022
Closed
Merged
@sg893052
Copy link
Contributor

@yxieca Could you please help assign someone to review fix PR #11243

qiluo-msft pushed a commit that referenced this issue Jun 29, 2022
@sg893052
Add yang model unit test for check_up_status field type (#11243)
dbc6681 
#### Why I did it
To address #11110 - Add yang model unit test for check_up_status field type

#### How I did it
Add check_up_status with different values in sample_config_db.json and
the field with correct and incorrect values in feature.json

#### How to verify it
Build sonic_yang_models-1.0-py3-none-any.whl
@zhangyanzhao
Copy link
Collaborator

#11243 is merged. @qiluo-msft please close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sg893052 sg893052

Labels
Triaged this issue has been triaged YANG YANG model related changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zhangyanzhao @qiluo-msft @yxieca @sg893052