Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weighted-Cost Multi-Path HLD #1629

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Mar 8, 2024

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

This document provides general information about Weighted-Cost Multi-Path implementation in SONiC

In scope: W-ECMP L3 configuration

Out of scope: W-ECMP EVPN Type-5 configuration

PR title state context
BGP OA GitHub issue/pull request detail GitHub pull request check contexts
CLI GitHub issue/pull request detail GitHub pull request check contexts
Test Plan GitHub issue/pull request detail GitHub pull request check contexts

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@zhangyanzhao
Copy link
Collaborator

community review recording https://zoom.us/rec/share/Wlvm6_mZtV5Ov-QihEY_bt3JxVFlizC7jRMIwVQKwNJy4s2Ub5sXuRzAV0dyj1Aa.3uxRviw8exKORObs

@liat-grozovik
Copy link
Collaborator

@kperumalbfn @philo-micas any further comments or you will be able to approve the HLD?
Code PRs are avaialble, do you wish to take part of the PRs review as well?

@zhangyanzhao need to track it for 202405. This feature need to get in.

@zhangyanzhao
Copy link
Collaborator

@zhangyanzhao zhangyanzhao requested a review from tjchadaga April 16, 2024 15:32
@zhangyanzhao
Copy link
Collaborator

Add @tjchadaga as reviewer and please help to review this PR.

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@liat-grozovik
Copy link
Collaborator

@philo-micas @venkatmahalingam kindly reminder to review and approve if all comments were handled

@lguohan
Copy link
Contributor

lguohan commented May 12, 2024

@philo-micas , @venkatmahalingam , what is pending on this HLD?

@venkatmahalingam
Copy link
Collaborator

@philo-micas , @venkatmahalingam , what is pending on this HLD?

Let me take a look again.

@liat-grozovik liat-grozovik merged commit cf8c566 into sonic-net:master May 22, 2024
1 check passed
@zhangyanzhao
Copy link
Collaborator

Nvidia will link the test PR and BRCM will help to review the code PRs. @adyeung @liat-grozovik

@nazariig
Copy link
Collaborator Author

Nvidia will link the test PR and BRCM will help to review the code PRs. @adyeung @liat-grozovik

@zhangyanzhao done

@zhangyanzhao
Copy link
Collaborator

code PRs are still open, move to backlog for future release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: MovedToBacklog
Development

Successfully merging this pull request may close these issues.

8 participants