Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBAL Config Session Changes #1518

Merged
merged 1 commit into from
May 1, 2024
Merged

DBAL Config Session Changes #1518

merged 1 commit into from
May 1, 2024

Conversation

a-barboza
Copy link
Collaborator

@a-barboza a-barboza commented Nov 16, 2023

Includes Config Session, Locking, Transaction Size Limit.

Repo Title Code PR
sonic-mgmt-common DB Access Layer: Config Session Infra sonic-net/sonic-mgmt-common#108

    Includes Config Session, Locking, Transaction Size Limit.
@a-barboza
Copy link
Collaborator Author

@adyeung @anand-kumar-subramanian @kwangsuk @ayelrod

This SONiC documentation PR has HLD descriptions for code PR sonic-net/sonic-mgmt-common#108

@kwangsuk
Copy link

@adyeung @anand-kumar-subramanian @kwangsuk @ayelrod

This SONiC documentation PR has HLD descriptions for code PR sonic-net/sonic-mgmt-common#108

What is a use case of "config session"?

@a-barboza
Copy link
Collaborator Author

@adyeung @anand-kumar-subramanian @kwangsuk @ayelrod
This SONiC documentation PR has HLD descriptions for code PR sonic-net/sonic-mgmt-common#108

What is a use case of "config session"?

It is to provide a way to configure/querying a candidate-datastore in addition to the already supported running-datastore, as mentioned on this line.

https://github.com/sonic-net/SONiC/pull/1518/files#diff-e2e75336c9fbe220dc4106f7285765590c328e1388bed83ce7df0ad468a73dbfR1484


This will be enhanced for the following:

* Provide a way for querying a *candidate-datastore*, instead of the redis server's CONFIG_DB database selection. This can be supported in one of several ways:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In continuation to my earlier question , can you provide a usecase of "candidate datastore" in the community?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In continuation to my earlier question , can you provide a usecase of "candidate datastore" in the community?

We are trying to get the Configuration Session functionality in. These DB Access Layer changes are one foundation for Configuration Session support.

The terms are defined in RESTCONF, and NETCONF protocols here.

RESTCONF -- Terminology -- NETCONF

NETCONF -- Terminology

@adyeung adyeung merged commit a23e80e into sonic-net:master May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants