Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around issue building wheels on M1 macs by passing --use-pep517 to pip #12

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

gmishkin
Copy link
Collaborator

@gmishkin gmishkin commented Feb 10, 2022

On an M1 Mac, getting almost the same error as this when installing pycares using a custom universal2 python 3.8 build

This message led me to look into PEP 517 and I noticed that pip has an option to use it (why it's not the default appears to be a long story).

I'm sure there are downsides, and perhaps this could be opt-in instead, but the idea behind PEP 517 seemed sort of bazel-y so it felt sensible to have it on by default here.

@NathanHowell
Copy link
Contributor

have you had any build failures with this? I'm assuming the impact is slightly slower wheel builds, when those are necessary?

@gmishkin
Copy link
Collaborator Author

gmishkin commented Feb 11, 2022

Nope and we have about 140 packages in our list of pins.

Yes they make it sound like it would be slower. I can't actually tell when it's necessary. I know the rule calls pip wheel which based on the description makes it sound like it builds it unconditionally. I can't tell whether some other mechanism sneaks in there and downloads pre-built wheels from the Internet when available.

Copy link
Contributor

@NathanHowell NathanHowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me locally on a variety of deps. If we hear of any issues let's add a flag to disable this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants